Skip to content

Commit 7a65a61

Browse files
authored
Remove CONTRIBUTING.md policy requiring tests be run for vendored dependencies (#6586)
This policy existed to ensure that, when updating a dependency to a non-release-tagged commit, we weren't accidentally bringing in a broken version of that dependency. Since it was instituted, we have greatly reduced the number of non-versioned dependencies. And we have extensive tests of our own that should detect if any of the behavior we use from one of these dependencies is broken. Therefore this requirement has fallen by the wayside. Update the document to reflect current practices.
1 parent 1f6a873 commit 7a65a61

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

docs/CONTRIBUTING.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ guidelines for Boulder contributions.
2020
* You cannot review your own code.
2121
* If a branch contains commits from multiple authors, it needs a reviewer who
2222
is not an author of commits on that branch.
23-
* If a branch contains updates to files in the vendor/ directory, the author is
24-
responsible for running tests in all updated dependencies, and commenting in
25-
the review thread that they have done so. Reviewers must not approve reviews
26-
that have changes in vendor/ but lack a comment about tests.
2723
* Review changes to or addition of tests just as rigorously as you review code
2824
changes. Consider: Do tests actually test what they mean to test? Is this the
2925
best way to test the functionality in question? Do the tests cover all the

0 commit comments

Comments
 (0)