Changed my mind, we've already logged the cert at this point

aarongable · aarongable · commit 8d5421e4cb22 · 2025-12-16T13:43:30.000-08:00
diff --git a/ca/ca.go b/ca/ca.go
@@ -450,7 +450,7 @@ func (ca *certificateAuthorityImpl) IssueCertificate(ctx context.Context, req *c
 		Issued: timestamppb.New(ca.clk.Now()),
 	})
 	if err != nil {
-		ca.log.AuditErrf("Failed RPC to store at SA: serial=[%s] cert=[%v] err=[%v]", serialHex, hex.EncodeToString(certDER), err)
+		ca.log.AuditErrf("Failed RPC to store at SA: serial=[%s] err=[%v]", serialHex, err)
 		return nil, fmt.Errorf("persisting cert to database: %w", err)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -450,7 +450,7 @@ func (ca certificateAuthorityImpl) IssueCertificate(ctx context.Context, req c`
`450`	`450`	`Issued: timestamppb.New(ca.clk.Now()),`
`451`	`451`	`})`
`452`	`452`	`if err != nil {`
`453`		`- ca.log.AuditErrf("Failed RPC to store at SA: serial=[%s] cert=[%v] err=[%v]", serialHex, hex.EncodeToString(certDER), err)`
	`453`	`+ ca.log.AuditErrf("Failed RPC to store at SA: serial=[%s] err=[%v]", serialHex, err)`
`454`	`454`	`return nil, fmt.Errorf("persisting cert to database: %w", err)`
`455`	`455`	`}`
`456`	`456`