Remove some context assumptions

Author: jsha

db/multi.go

@@ -102,9 +102,8 @@ func (mi *MultiInserter) query() (string, []interface{}) {
 }
 
 // Insert inserts all the collected rows into the database represented by
-// `queryer`. `queryer` is assumed to already have a context attached. If a
-// non-empty returningColumn was provided, then it returns the list of values
-// from that column returned by the query.
+// `queryer`. If a non-empty returningColumn was provided, then it returns
+// the list of values from that column returned by the query.
 func (mi *MultiInserter) Insert(ctx context.Context, queryer Queryer) ([]int64, error) {
 	query, queryArgs := mi.query()
 	rows, err := queryer.QueryContext(ctx, query, queryArgs...)

sa/model.go

@@ -1002,8 +1002,7 @@ var blockedKeysColumns = "keyHash, added, source, comment"
 //   - If all of the order's authorizations are valid, and we haven't begun
 //     processing, then the order is status ready.
 //
-// An error is returned for any other case. It assumes that the provided
-// database selector already has a context associated with it.
+// An error is returned for any other case.
 func statusForOrder(ctx context.Context, s db.Selector, order *corepb.Order, now time.Time) (string, error) {
 	// Without any further work we know an order with an error is invalid
 	if order.Error != nil {
@@ -1119,8 +1118,7 @@ type authzValidity struct {
 }
 
 // getAuthorizationStatuses takes a sequence of authz IDs, and returns the
-// status and expiration date of each of them. It assumes that the provided
-// database selector already has a context associated with it.
+// status and expiration date of each of them.
 func getAuthorizationStatuses(ctx context.Context, s db.Selector, ids []int64) ([]authzValidity, error) {
 	var params []interface{}
 	for _, id := range ids {
@@ -1151,8 +1149,7 @@ func getAuthorizationStatuses(ctx context.Context, s db.Selector, ids []int64) (
 	return allAuthzValidity, nil
 }
 
-// authzForOrder retrieves the authorization IDs for an order. It assumes that
-// the provided database selector already has a context associated with it.
+// authzForOrder retrieves the authorization IDs for an order.
 func authzForOrder(ctx context.Context, s db.Selector, orderID int64) ([]int64, error) {
 	var v2IDs []int64
 	_, err := s.Select(
@@ -1165,8 +1162,7 @@ func authzForOrder(ctx context.Context, s db.Selector, orderID int64) ([]int64,
 }
 
 // namesForOrder finds all of the requested names associated with an order. The
-// names are returned in their reversed form (see `sa.ReverseName`). It assumes
-// that the provided database selector already has a context associated with it.
+// names are returned in their reversed form (see `sa.ReverseName`).
 func namesForOrder(ctx context.Context, s db.Selector, orderID int64) ([]string, error) {
 	var reversedNames []string
 	_, err := s.Select(

sa/rate_limits.go

@@ -30,8 +30,7 @@ func baseDomain(name string) string {
 
 // addCertificatesPerName adds 1 to the rate limit count for the provided
 // domains, in a specific time bucket. It must be executed in a transaction, and
-// the input timeToTheHour must be a time rounded to an hour. It assumes that
-// the given db already has a context associated with it.
+// the input timeToTheHour must be a time rounded to an hour.
 func (ssa *SQLStorageAuthority) addCertificatesPerName(ctx context.Context, db db.SelectExecer, names []string, timeToTheHour time.Time) error {
 	// De-duplicate the base domains.
 	baseDomainsMap := make(map[string]bool)
@@ -57,8 +56,7 @@ func (ssa *SQLStorageAuthority) addCertificatesPerName(ctx context.Context, db d
 }
 
 // countCertificates returns the count of certificates issued for a domain's
-// eTLD+1 (aka base domain), during a given time range. It assumes that the
-// given db already has a context associated with it.
+// eTLD+1 (aka base domain), during a given time range.
 func (ssa *SQLStorageAuthorityRO) countCertificates(ctx context.Context, dbMap db.Selector, domain string, timeRange *sapb.Range) (int64, time.Time, error) {
 	latest := time.Unix(0, timeRange.Latest)
 	var results []struct {
@@ -102,8 +100,7 @@ func (ssa *SQLStorageAuthorityRO) countCertificates(ctx context.Context, dbMap d
 
 // addNewOrdersRateLimit adds 1 to the rate limit count for the provided ID, in
 // a specific time bucket. It must be executed in a transaction, and the input
-// timeToTheMinute must be a time rounded to a minute. It assumes that the given
-// db already has a context associated with it.
+// timeToTheMinute must be a time rounded to a minute.
 func addNewOrdersRateLimit(ctx context.Context, dbMap db.SelectExecer, regID int64, timeToTheMinute time.Time) error {
 	_, err := dbMap.ExecContext(ctx, `INSERT INTO newOrdersRL
 		(regID, time, count)
@@ -119,8 +116,7 @@ func addNewOrdersRateLimit(ctx context.Context, dbMap db.SelectExecer, regID int
 }
 
 // countNewOrders returns the count of orders created in the given time range
-// for the given registration ID. It assumes that the given db already has a
-// context associated with it.
+// for the given registration ID.
 func countNewOrders(ctx context.Context, dbMap db.Selector, req *sapb.CountOrdersRequest) (*sapb.Count, error) {
 	var counts []int64
 	_, err := dbMap.Select(