lint: fix staticcheck QF issues (#8524)

This PR fixes these staticcheck lint issues:

This partially addresses the TODO comment:

https://github.com/letsencrypt/boulder/blob/be957c2242aa543549f28d41048ea3abee30a20b/.golangci.yml#L67-L70

Author: alexandear

.golangci.yml

@@ -75,12 +75,7 @@ linters:
         - -ST1003 # Poorly chosen identifier
         - -ST1005 # Incorrectly formatted error string
         - -QF1001 # Could apply De Morgan's law
-        - -QF1003 # Could use tagged switch
-        - -QF1004 # Could use strings.Split instead
-        - -QF1007 # Could merge conditional assignment into variable declaration
         - -QF1008 # Could remove embedded field from selector
-        - -QF1009 # Probably want to use time.Time.Equal
-        - -QF1012 # Use fmt.Fprintf(...) instead of Write(fmt.Sprintf(...))
   exclusions:
     presets:
       - std-error-handling

log/log.go

@@ -186,7 +186,7 @@ func (w *bothWriter) logAtLevel(level syslog.Priority, msg string, a ...any) {
 
 	// Since messages are delimited by newlines, we have to escape any internal or
 	// trailing newlines before generating the checksum or outputting the message.
-	msg = strings.Replace(msg, "\n", "\\n", -1)
+	msg = strings.ReplaceAll(msg, "\n", "\\n")
 
 	w.Lock()
 	defer w.Unlock()
@@ -232,7 +232,7 @@ func (w *stdoutWriter) logAtLevel(level syslog.Priority, msg string, a ...any) {
 			msg = fmt.Sprintf(msg, a...)
 		}
 
-		msg = strings.Replace(msg, "\n", "\\n", -1)
+		msg = strings.ReplaceAll(msg, "\n", "\\n")
 
 		var color string
 		var reset string

mocks/sa.go

@@ -246,9 +246,10 @@ func (sa *StorageAuthorityReadOnly) FQDNSetExists(_ context.Context, _ *sapb.FQD
 
 // GetOrder is a mock
 func (sa *StorageAuthorityReadOnly) GetOrder(_ context.Context, req *sapb.OrderRequest, _ ...grpc.CallOption) (*corepb.Order, error) {
-	if req.Id == 2 {
+	switch req.Id {
+	case 2:
 		return nil, berrors.NotFoundError("bad")
-	} else if req.Id == 3 {
+	case 3:
 		return nil, errors.New("very bad")
 	}
 

policy/pa.go

@@ -388,7 +388,7 @@ func ValidEmail(address string) error {
 	if err != nil {
 		return berrors.InvalidEmailError("unable to parse email address")
 	}
-	splitEmail := strings.SplitN(email.Address, "@", -1)
+	splitEmail := strings.Split(email.Address, "@")
 	domain := strings.ToLower(splitEmail[len(splitEmail)-1])
 	err = validNonWildcardDomain(domain)
 	if err != nil {

publisher/publisher_test.go

@@ -67,10 +67,7 @@ func logSrv(k *ecdsa.PrivateKey) *testLogSrv {
 		if err != nil {
 			return
 		}
-		precert := false
-		if r.URL.Path == "/ct/v1/add-pre-chain" {
-			precert = true
-		}
+		precert := r.URL.Path == "/ct/v1/add-pre-chain"
 		sct := CreateTestingSignedSCT(jsonReq.Chain, k, precert, time.Now())
 		fmt.Fprint(w, string(sct))
 		atomic.AddInt64(&testLog.submissions, 1)
@@ -92,10 +89,7 @@ func lyingLogSrv(k *ecdsa.PrivateKey, timestamp time.Time) *testLogSrv {
 		if err != nil {
 			return
 		}
-		precert := false
-		if r.URL.Path == "/ct/v1/add-pre-chain" {
-			precert = true
-		}
+		precert := r.URL.Path == "/ct/v1/add-pre-chain"
 		sct := CreateTestingSignedSCT(jsonReq.Chain, k, precert, timestamp)
 		fmt.Fprint(w, string(sct))
 		atomic.AddInt64(&testLog.submissions, 1)

ra/ra_test.go

@@ -667,7 +667,7 @@ func TestPerformValidationSuccess(t *testing.T) {
 
 		// Check that validated timestamp was recorded, stored, and retrieved
 		expectedValidated := fc.Now()
-		test.Assert(t, *challenge.Validated == expectedValidated, "Validated timestamp incorrect or missing")
+		test.AssertEquals(t, *challenge.Validated, expectedValidated)
 	}
 }
 
@@ -879,7 +879,7 @@ func TestPerformValidationVAError(t *testing.T) {
 
 	// Check that validated timestamp was recorded, stored, and retrieved
 	expectedValidated := fc.Now()
-	test.Assert(t, *challenge.Validated == expectedValidated, "Validated timestamp incorrect or missing")
+	test.AssertEquals(t, *challenge.Validated, expectedValidated)
 }
 
 func TestCertificateKeyNotEqualAccountKey(t *testing.T) {

test/certs/webpki.go

@@ -107,7 +107,7 @@ func main() {
 			// template files) are meaningful and are consumed by aia-test-srv. If
 			// you change the structure of these file names, you will need to change
 			// aia-test-srv as well to recognize and consume the resulting files.
-			fileName := strings.Replace(name, " ", "-", -1)
+			fileName := strings.ReplaceAll(name, " ", "-")
 
 			// Create SoftHSM slot
 			keySlot, err := createSlot(name)

test/s3-test-srv/main.go

@@ -22,11 +22,12 @@ type s3TestSrv struct {
 }
 
 func (srv *s3TestSrv) handleS3(w http.ResponseWriter, r *http.Request) {
-	if r.Method == "PUT" {
+	switch r.Method {
+	case "PUT":
 		srv.handleUpload(w, r)
-	} else if r.Method == "GET" {
+	case "GET":
 		srv.handleDownload(w, r)
-	} else {
+	default:
 		w.WriteHeader(http.StatusMethodNotAllowed)
 	}
 }