Skip to content

Commit db2857b

Browse files
authored
Run PKILint in config integration tests (#7524)
This was introduced in config-next in #7441, and has been working well. We should run it in the mainline tests as well. No production config change is necessary.
1 parent 13d2544 commit db2857b

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

test/config/ca.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,7 @@
125125
}
126126
}
127127
],
128+
"lintConfig": "test/config/zlint.toml",
128129
"ignoredLints": [
129130
"w_subject_common_name_included",
130131
"w_sub_cert_aia_contains_internal_names"

test/config/zlint.toml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
[e_pkilint_lint_cabf_serverauth_cert]
2+
pkilint_addr = "http://10.77.77.9"
3+
pkilint_timeout = 200000000 # 200 milliseconds
4+
ignore_lints = [
5+
# We include the CN in (almost) all of our certificates, on purpose.
6+
# See https://github.com/letsencrypt/boulder/issues/5112 for details.
7+
"DvSubcriberAttributeAllowanceValidator:cabf.serverauth.dv.common_name_attribute_present",
8+
# We include the SKID in all of our certs, on purpose.
9+
# See https://github.com/letsencrypt/boulder/issues/7446 for details.
10+
"SubscriberExtensionAllowanceValidator:cabf.serverauth.subscriber.subject_key_identifier_extension_present",
11+
# We compute the skid using RFC7093 Method 1, on purpose.
12+
# See https://github.com/letsencrypt/boulder/pull/7179 for details.
13+
"SubjectKeyIdentifierValidator:pkix.subject_key_identifier_rfc7093_method_1_identified",
14+
# We include the keyEncipherment key usage in RSA certs, on purpose.
15+
# It is only necessary for old versions of TLS, and is included for backwards
16+
# compatibility. We intend to remove this in the short-lived profile.
17+
"SubscriberKeyUsageValidator:cabf.serverauth.subscriber_rsa_digitalsignature_and_keyencipherment_present",
18+
]

0 commit comments

Comments
 (0)