Skip to content

Commit 81f971d

Browse files
julesvanriegithub-actions
julesvanrie
and
github-actions
authored
Fix browser (#328)
* Remove instructions to install Chrome Even non-mainstream browsers are either build on the Chromium engine or on the Firefox engine, so we can safely let students choose their preferred browser. * Remove redundant details closure tag * Retrieve Windows BROWSER setting from backup The dotfiles installer removes the browser settings we set earlier. We can easily restore them from the backup file. Fixes #311 * setup guides generated --------- Co-authored-by: github-actions <github-actions@github.com>
1 parent 25871f6 commit 81f971d

File tree

12 files changed

+26
-97
lines changed

12 files changed

+26
-97
lines changed

‎LINUX.es.md‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -129,17 +129,6 @@ gh --version
129129
:x: Si no es el caso, por favor **contacta a un profesor**
130130

131131

132-
## Chrome - tu navegador
133-
134-
Instala el navegador Google Chrome si no lo tienes todavía y configúralo como tu __navegador predeterminado__.
135-
136-
Sigue los pasos en el siguiente enlace :point_right: [Instalación de Google Chrome](https://support.google.com/chrome/answer/95346?co=GENIE.Platform%3DDesktop&hl=en-GB)
137-
138-
__¿Por qué Chrome?__
139-
140-
Lo recomendamos como navegador predeterminado porque es el más compatible con los tests y la ejecución de código. Además trabaja con Google Cloud Platform. Otra opción es Firefox. No recomendamos usar otros navegadores como Opera, Internet Explorer o Safari.
141-
142-
143132
## Oh-my-zsh
144133

145134
Instalemos el plugin `zsh` [Oh My Zsh](https://ohmyz.sh/).

‎LINUX.md‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -153,17 +153,6 @@ gh --version
153153
:x: Otherwise, please **contact a teacher**
154154

155155

156-
## Chrome - your browser
157-
158-
Install the Google Chrome browser if you haven't got it already and set it as a __default browser__.
159-
160-
Follow the steps for your system from this link :point_right: [Install Google Chrome](https://support.google.com/chrome/answer/95346?co=GENIE.Platform%3DDesktop&hl=en-GB)
161-
162-
__Why Chrome?__
163-
164-
We recommend to use it as your default browser as it's most compatible with testing or running your code, as well as working with Google Cloud Platform. Another alternative is Firefox, however we don't recommend using other tools like Opera, Internet Explorer or Safari.
165-
166-
167156
## Oh-my-zsh
168157

169158
Let's install the `zsh` plugin [Oh My Zsh](https://ohmyz.sh/).
@@ -450,7 +439,6 @@ cd ~/code/$GITHUB_USERNAME/dotfiles && zsh git_setup.sh
450439
:warning: You **need** to put one of the emails listed above thanks to the previous `gh api ...` command. If you don't do that, Kitt won't be able to track your progress. 💡 Select the `@users.noreply.github.com` address if you don't want your email to appear in public repositories you may contribute to.
451440

452441
Please now **quit** all your opened terminal windows.
453-
</details>
454442

455443

456444
## Disable SSH passphrase prompt

‎VM.es.md‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,6 @@ Por favor **léelas cuidadosamente y ejecuta todos los comandos en el siguiente
77
¡Comencemos! :rocket:
88

99

10-
## Chrome - tu navegador
11-
12-
Instala el navegador Google Chrome si no lo tienes todavía y configúralo como tu __navegador predeterminado__.
13-
14-
Sigue los pasos en el siguiente enlace :point_right: [Instalación de Google Chrome](https://support.google.com/chrome/answer/95346?co=GENIE.Platform%3DDesktop&hl=en-GB)
15-
16-
__¿Por qué Chrome?__
17-
18-
Lo recomendamos como navegador predeterminado porque es el más compatible con los tests y la ejecución de código. Además trabaja con Google Cloud Platform. Otra opción es Firefox. No recomendamos usar otros navegadores como Opera, Internet Explorer o Safari.
19-
20-
2110
## Cuenta GitHub
2211

2312
¿Ya tienes una cuenta GitHub? Si no es el caso, [ábrela ya](https://github.com/join).

‎VM.md‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,6 @@ Please **read them carefully and execute all commands in the following order**.
77
Let's start :rocket:
88

99

10-
## Chrome - your browser
11-
12-
Install the Google Chrome browser if you haven't got it already and set it as a __default browser__.
13-
14-
Follow the steps for your system from this link :point_right: [Install Google Chrome](https://support.google.com/chrome/answer/95346?co=GENIE.Platform%3DDesktop&hl=en-GB)
15-
16-
__Why Chrome?__
17-
18-
We recommend to use it as your default browser as it's most compatible with testing or running your code, as well as working with Google Cloud Platform. Another alternative is Firefox, however we don't recommend using other tools like Opera, Internet Explorer or Safari.
19-
20-
2110
## GitHub account
2211

2312
Have you signed up to GitHub? If not, [do it right away](https://github.com/join).
@@ -874,7 +863,6 @@ cd ~/code/$GITHUB_USERNAME/dotfiles && zsh git_setup.sh
874863
:warning: You **need** to put one of the emails listed above thanks to the previous `gh api ...` command. If you don't do that, Kitt won't be able to track your progress. 💡 Select the `@users.noreply.github.com` address if you don't want your email to appear in public repositories you may contribute to.
875864

876865
Please now **quit** all your opened terminal windows.
877-
</details>
878866

879867

880868
### zsh default terminal

‎WINDOWS.es.md‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -379,17 +379,6 @@ sudo apt-get install language-pack-en language-pack-en-base manpages
379379
</details>
380380

381381

382-
## Chrome - tu navegador
383-
384-
Instala el navegador Google Chrome si no lo tienes todavía y configúralo como tu __navegador predeterminado__.
385-
386-
Sigue los pasos en el siguiente enlace :point_right: [Instalación de Google Chrome](https://support.google.com/chrome/answer/95346?co=GENIE.Platform%3DDesktop&hl=en-GB)
387-
388-
__¿Por qué Chrome?__
389-
390-
Lo recomendamos como navegador predeterminado porque es el más compatible con los tests y la ejecución de código. Además trabaja con Google Cloud Platform. Otra opción es Firefox. No recomendamos usar otros navegadores como Opera, Internet Explorer o Safari.
391-
392-
393382
## Visual Studio Code
394383

395384
### Instalación
@@ -1129,6 +1118,13 @@ curl $SOURCE > $LOCATION/custom.css
11291118

11301119
### Configuración de Jupyter Notebook para abrirlo en tu navegador
11311120

1121+
Primero, vamos a configurar tu navegador predeterminado nuevamente. Ya hicimos esto antes, pero cuando instalamos los dotfiles se eliminó la configuración. No hay problema, ejecuta este comando para volver a configurarlo:
1122+
1123+
```bash
1124+
grep -E "export (GH_)*BROWSER" .zshrc.backup >> .zshrc
1125+
```
1126+
1127+
11321128
Genera el archivo de configuración para **Jupyter Notebook**...
11331129

11341130
``` bash

‎WINDOWS.md‎

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -381,17 +381,6 @@ sudo apt-get install language-pack-en language-pack-en-base manpages
381381
</details>
382382

383383

384-
## Chrome - your browser
385-
386-
Install the Google Chrome browser if you haven't got it already and set it as a __default browser__.
387-
388-
Follow the steps for your system from this link :point_right: [Install Google Chrome](https://support.google.com/chrome/answer/95346?co=GENIE.Platform%3DDesktop&hl=en-GB)
389-
390-
__Why Chrome?__
391-
392-
We recommend to use it as your default browser as it's most compatible with testing or running your code, as well as working with Google Cloud Platform. Another alternative is Firefox, however we don't recommend using other tools like Opera, Internet Explorer or Safari.
393-
394-
395384
## Visual Studio Code
396385

397386
### Installation
@@ -1007,7 +996,6 @@ cd ~/code/$GITHUB_USERNAME/dotfiles && zsh git_setup.sh
1007996
:warning: You **need** to put one of the emails listed above thanks to the previous `gh api ...` command. If you don't do that, Kitt won't be able to track your progress. 💡 Select the `@users.noreply.github.com` address if you don't want your email to appear in public repositories you may contribute to.
1008997

1009998
Please now **quit** all your opened terminal windows.
1010-
</details>
1011999

10121000

10131001
## Disable SSH passphrase prompt
@@ -1187,6 +1175,12 @@ curl $SOURCE > $LOCATION/custom.css
11871175

11881176
### Configuring Jupyter Notebook to open in your browser
11891177

1178+
First, let's configure your default browser again. We did this before, but when we installed the dotfiles it got removed. Not a problem, run this command to configure the settings again:
1179+
1180+
```bash
1181+
grep -E "export (GH_)*BROWSER" .zshrc.backup >> .zshrc
1182+
```
1183+
11901184
Let's generate the configuration file for **Jupyter Notebook**...
11911185

11921186
``` bash

‎_partials/dotfiles_installer.md‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,3 @@ cd ~/code/$GITHUB_USERNAME/dotfiles && zsh git_setup.sh
2222
:warning: You **need** to put one of the emails listed above thanks to the previous `gh api ...` command. If you don't do that, Kitt won't be able to track your progress. 💡 Select the `@users.noreply.github.com` address if you don't want your email to appear in public repositories you may contribute to.
2323

2424
Please now **quit** all your opened terminal windows.
25-
</details>

‎_partials/es/win_jupyter.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
### Configuración de Jupyter Notebook para abrirlo en tu navegador
22

3+
Primero, vamos a configurar tu navegador predeterminado nuevamente. Ya hicimos esto antes, pero cuando instalamos los dotfiles se eliminó la configuración. No hay problema, ejecuta este comando para volver a configurarlo:
4+
5+
```bash
6+
grep -E "export (GH_)*BROWSER" .zshrc.backup >> .zshrc
7+
```
8+
9+
310
Genera el archivo de configuración para **Jupyter Notebook**...
411

512
``` bash

‎_partials/win_jupyter.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11

22
### Configuring Jupyter Notebook to open in your browser
33

4+
First, let's configure your default browser again. We did this before, but when we installed the dotfiles it got removed. Not a problem, run this command to configure the settings again:
5+
6+
```bash
7+
grep -E "export (GH_)*BROWSER" .zshrc.backup >> .zshrc
8+
```
9+
410
Let's generate the configuration file for **Jupyter Notebook**...
511

612
``` bash

‎build.rb‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
osx_silicon
1717
setup/macos_command_line_tools
1818
homebrew
19-
chrome
2019
setup/macos_vscode
2120
vscode_extensions
2221
setup/oh_my_zsh
@@ -60,7 +59,6 @@
6059
setup/windows_virtualization
6160
setup/windows_wsl
6261
setup/windows_ubuntu
63-
chrome
6462
setup/windows_vscode
6563
setup/windows_terminal
6664
vscode_extensions
@@ -109,7 +107,6 @@
109107
setup/ubuntu_vscode
110108
vscode_extensions
111109
setup/cli_tools
112-
chrome
113110
setup/oh_my_zsh
114111
direnv
115112
setup/gh_cli
@@ -146,7 +143,6 @@
146143

147144
VM = %w[
148145
intro
149-
chrome
150146
setup/github
151147
de_setup/ssh_key
152148
de_setup/gcp_setup

0 commit comments

Comments
 (0)