move: DisplayMs to common::time

It seems we're using this in more than `lexe-api`, so might as well make
it more broadly available.

Author: MaxFangX

common/src/lib.rs

@@ -61,7 +61,7 @@ pub mod root_seed;
 pub mod task;
 /// `TestEvent`.
 pub mod test_event;
-/// `TimestampMs`
+/// `TimestampMs` and `DisplayMs`.
 pub mod time;
 
 /// Feature-gated test utilities that can be shared across crate boundaries.

common/src/time.rs

@@ -6,6 +6,19 @@ use std::{
 
 use serde::{de, Serialize};
 
+/// [`Display`]s a [`Duration`] in ms with 3 decimal places, e.g. "123.456ms".
+///
+/// Useful to log elapsed times in a consistent unit, as [`Duration`]'s default
+/// implementation will go with seconds, ms, nanos etc depending on the value.
+pub struct DisplayMs(pub Duration);
+
+impl Display for DisplayMs {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        let ms = self.0.as_secs_f64() * 1000.0;
+        write!(f, "{ms:.3}ms")
+    }
+}
+
 /// The number of milliseconds since the [`UNIX_EPOCH`].
 ///
 /// - Internally represented by a non-negative [`i64`] to ease interoperability

lexe-api/src/rest.rs

@@ -6,6 +6,7 @@ use common::{
         ApiError, CommonApiError, CommonErrorKind, ErrorCode, ErrorResponse,
     },
     backoff, ed25519,
+    time::DisplayMs,
 };
 use http::{
     header::{HeaderValue, CONTENT_TYPE},
@@ -16,8 +17,7 @@ use reqwest::IntoUrl;
 use serde::{de::DeserializeOwned, Serialize};
 use tracing::{debug, info, warn, Instrument};
 
-use super::trace::TraceId;
-use crate::trace::{self, DisplayMs};
+use crate::{trace, trace::TraceId};
 
 /// The CONTENT-TYPE header for signed BCS-serialized structs.
 pub static CONTENT_TYPE_ED25519_BCS: HeaderValue =

lexe-api/src/trace.rs

@@ -8,7 +8,7 @@ use std::{
 };
 
 use anyhow::{bail, ensure, Context};
-use common::rng::ThreadFastRng;
+use common::{rng::ThreadFastRng, time::DisplayMs};
 use http::{HeaderName, HeaderValue};
 use rand_core::RngCore;
 use tracing::{span, warn, Dispatch};
@@ -352,17 +352,6 @@ macro_rules! define_trace_id_fns {
     };
 }
 
-/// [`Display`]s a [`Duration`] in ms with 3 decimal places, e.g. "123.456ms".
-/// Used to log request / response times in a consistent unit.
-pub struct DisplayMs(pub Duration);
-
-impl Display for DisplayMs {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        let ms = self.0.as_secs_f64() * 1000.0;
-        write!(f, "{ms:.3}ms")
-    }
-}
-
 /// Client tracing utilities.
 pub(crate) mod client {
     use tracing::info_span;

node/src/event_handler.rs

@@ -565,7 +565,7 @@ async fn do_handle_event(
 mod anonymize {
     use std::collections::HashSet;
 
-    use lexe_api::trace::DisplayMs;
+    use common::time::DisplayMs;
     use lightning::{
         events::PathFailure,
         ln::{channelmanager::PaymentId, PaymentHash},