auth: test bcs + signing roundtrip

Author: phlip9

common/src/auth.rs

@@ -1,5 +1,7 @@
 // user auth v1
 
+#[cfg(test)]
+use proptest_derive::Arbitrary;
 use serde::{Deserialize, Serialize};
 use thiserror::Error;
 
@@ -14,7 +16,8 @@ pub enum Error {
 
 // TODO(phlip9): do we even need any signup fields?
 /// Sign up
-#[derive(Deserialize, Serialize)]
+#[derive(Debug, PartialEq, Deserialize, Serialize)]
+#[cfg_attr(test, derive(Arbitrary))]
 pub struct UserSignupRequest {
     pub display_name: Option<String>,
     pub email: Option<String>,
@@ -62,3 +65,19 @@ impl ed25519::Signable for UserSignupRequest {
     const DOMAIN_SEPARATOR_STR: &'static [u8] =
         b"LEXE-REALM::UserSignupRequest";
 }
+
+#[cfg(test)]
+mod test {
+    use super::*;
+    use crate::test_utils::{assert_bcs_roundtrip, assert_signed_roundtrip};
+
+    #[test]
+    fn test_user_signup_request_canonical() {
+        assert_bcs_roundtrip::<UserSignupRequest>();
+    }
+
+    #[test]
+    fn test_user_signed_request_sign_verify() {
+        assert_signed_roundtrip::<UserSignupRequest>();
+    }
+}

common/src/lib.rs

@@ -32,6 +32,9 @@ pub mod sha256;
 pub mod shutdown;
 pub mod task;
 
+#[cfg(test)]
+pub mod test_utils;
+
 /// Assert at compile time that two `usize` values are equal. This assert has a
 /// nice benefit where there compiler error will actually _print out_ the
 /// two values.

common/src/test_utils.rs

@@ -0,0 +1,37 @@
+use proptest::arbitrary::Arbitrary;
+use proptest::proptest;
+use serde::de::DeserializeOwned;
+use serde::Serialize;
+
+use crate::ed25519;
+
+pub fn assert_bcs_roundtrip<T>()
+where
+    T: Arbitrary + PartialEq + Serialize + DeserializeOwned,
+{
+    proptest!(|(value: T)| {
+        let ser_value = bcs::to_bytes(&value).unwrap();
+        let value2 = bcs::from_bytes::<T>(&ser_value).unwrap();
+        let ser_value2 = bcs::to_bytes(&value2).unwrap();
+
+        assert_eq!(&value, &value2);
+        assert_eq!(&ser_value, &ser_value2);
+    });
+}
+
+pub fn assert_signed_roundtrip<T>()
+where
+    T: Arbitrary + PartialEq + Serialize + DeserializeOwned + ed25519::Signable,
+{
+    proptest!(|(seed: [u8; 32], value: T)| {
+        let key_pair = ed25519::KeyPair::from_seed(&seed);
+        let pubkey = key_pair.public_key();
+
+        let (ser_value, signed_value) = key_pair.sign_struct(&value).unwrap();
+        let signed_value2 = pubkey.verify_signed_struct(&ser_value).unwrap();
+        let (ser_value2, _) = key_pair.sign_struct(signed_value2.inner()).unwrap();
+
+        assert_eq!(signed_value, signed_value2.as_ref());
+        assert_eq!(&ser_value, &ser_value2);
+    });
+}