api: Deprecate get_new_payments

Author: MaxFangX

app-rs/src/client.rs

@@ -692,13 +692,9 @@ impl AppNodeRunApi for NodeClient {
 
     async fn get_new_payments(
         &self,
-        req: GetNewPayments,
+        _: GetNewPayments,
     ) -> Result<VecBasicPaymentV1, NodeApiError> {
-        self.ensure_authed().await?;
-        let run_url = &self.run_url;
-        let url = format!("{run_url}/app/payments/new");
-        let req = self.run_rest.get(url, &req);
-        self.run_rest.send(req).await
+        unimplemented!("Deprecated")
     }
 
     async fn get_updated_payments(

lexe-api-core/src/def.rs

@@ -360,6 +360,8 @@ pub trait AppNodeRunApi {
     ) -> Result<VecBasicPaymentV1, NodeApiError>;
 
     /// GET /app/payments/new [`GetNewPayments`] -> [`VecBasicPaymentV1`]
+    #[deprecated(note = "since app-v0.8.9+29 and sdk-sidecar-v0.3.1: \
+                         Use get_updated_payments instead")]
     async fn get_new_payments(
         &self,
         req: GetNewPayments,
@@ -785,6 +787,11 @@ pub trait NodeBackendApi {
     /// a known [`PaymentCreatedIndex`] (exclusive).
     /// Results are in ascending order, by `(created_at, payment_id)`.
     /// See [`GetNewPayments`] for more info.
+    #[deprecated(note = "since app-v0.8.9+29 and sdk-sidecar-v0.3.1: \
+                         Use get_updated_payments instead")]
+    // NOTE: This fn is used in the app->node handler for /app/payments/new, so
+    // the node->backend client code must remain until all app and sdk-sidecar
+    // clients have been updated.
     async fn get_new_payments(
         &self,
         req: GetNewPayments,

node/src/client.rs

@@ -575,6 +575,9 @@ impl NodeBackendApi for NodeBackendClient {
         req: GetNewPayments,
         auth: BearerAuthToken,
     ) -> Result<VecDbPaymentV1, BackendApiError> {
+        // NOTE: This fn is used in the app->node handler for /app/payments/new,
+        // so the node->backend client code must remain until all app and
+        // sdk-sidecar clients have been updated.
         let backend = &self.backend_url;
         let req = self
             .rest

node/src/persister.rs

@@ -470,6 +470,10 @@ impl NodePersister {
         req: GetNewPayments,
     ) -> anyhow::Result<Vec<BasicPaymentV1>> {
         let token = self.get_token().await?;
+        // NOTE: This fn is used in the app->node handler for /app/payments/new,
+        // so the node->backend client code must remain until all app and
+        // sdk-sidecar clients have been updated.
+        #[allow(deprecated)]
         self.backend_api
             .get_new_payments(req, token)
             .await