feat: improve abtract doctrine storage. Superseed #468 (#475)

Author: shakaran

Storage/AbstractDoctrineStorage.php

@@ -156,23 +156,33 @@ public function getTransUnitDomainsByLocale()
      */
     public function getTransUnitsByLocaleAndDomain($locale, $domain): array
     {
-        return $this->getTransUnitRepository()->getAllByLocaleAndDomain($locale, $domain);
+        return $this->getTransUnitRepository()->getAllByLocaleAndDomain(locale: $locale, domain: $domain);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getTransUnitList(?array $locales = null, $rows = 20, $page = 1, ?array $filters = null): array
+    public function getTransUnitList(?array $locales = null, ?int $rows = 20, ?int $page = 1, ?array $filters = null): array
     {
-        return $this->getTransUnitRepository()->getTransUnitList($locales, $rows, $page, $filters);
+        return $this->getTransUnitRepository()->getTransUnitList(locales: $locales, rows: $rows, page: $page, filters: $filters);
     }
 
     /**
      * {@inheritdoc}
      */
     public function countTransUnits(?array $locales = null, ?array $filters = null): int
     {
-        return $this->getTransUnitRepository()->count($locales, $filters);
+        $criteria = [
+            'locales' => $locales,
+            'filters' => $filters,
+        ];
+        if (null === $locales) {
+            unset($criteria['locales']);
+        }
+        if (null === $filters) {
+            unset($criteria['filters']);
+        }
+        return $this->getTransUnitRepository()->count(criteria: $criteria);
     }
 
     /**

Storage/StorageInterface.php

@@ -114,7 +114,7 @@ public function getTransUnitsByLocaleAndDomain($locale, $domain): array;
      * @param int   $page
      * @return array
      */
-    public function getTransUnitList(?array $locales = null, $rows = 20, $page = 1, ?array $filters = null): array;
+    public function getTransUnitList(?array $locales = null, ?int $rows = 20, ?int $page = 1, ?array $filters = null): array;
 
     /**
      * Count the number of trans unit.