Skip to content

Commit c212165

Browse files
Copilotlextm
andcommitted
Remove references to adding 'imported' label - it's only for CodePlex imports
Co-authored-by: lextm <425130+lextm@users.noreply.github.com>
1 parent ba27dd0 commit c212165

File tree

6 files changed

+7
-21
lines changed

6 files changed

+7
-21
lines changed

FAULTY_DEVICE_ISSUES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ The following imported issues are related to faulty devices but currently **miss
3232
- **Reason**: Device uses non-standard SNMP data type 18 that is not part of standard SNMP data types
3333

3434
### #101 - Cisco ASA 5510 MsgFlags Issue
35-
- **Status**: Needs tag (note: currently only has "bug" label, missing "imported" label too)
35+
- **Status**: Needs tag (note: currently only has "bug" label)
3636
- **Device**: Cisco ASA 5510 firewall
3737
- **Issue**: Returns MsgFlags=8 during SNMPv3 discovery, library only handles 0-7
3838
- **Reason**: Works in Net::SNMP, device returns out-of-spec value; Cisco C2960 switch works correctly

FAULTY_DEVICE_TAGGING_README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ Issues were identified as device-related if they met one or more of these criter
3535
- #436: Cisco switch - MAC address per VLAN (needs VLAN context)
3636
- #475: Citrix Xen - GetTable timeout (works in iReasoning)
3737

38-
**Note:** Issue #101 also needs the "imported" label added.
39-
4038
## Files Created
4139

4240
### 1. `FAULTY_DEVICE_ISSUES.md`
@@ -81,7 +79,7 @@ Navigate to each issue and add the `area:faulty-device` label:
8179
```bash
8280
gh issue edit 62 --add-label "area:faulty-device"
8381
gh issue edit 89 --add-label "area:faulty-device"
84-
gh issue edit 101 --add-label "area:faulty-device,imported"
82+
gh issue edit 101 --add-label "area:faulty-device"
8583
gh issue edit 370 --add-label "area:faulty-device"
8684
gh issue edit 436 --add-label "area:faulty-device"
8785
gh issue edit 475 --add-label "area:faulty-device"

PR_SUMMARY.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ This PR provides a comprehensive review of all imported issues to identify which
5050
| [#436](https://github.com/lextudio/sharpsnmplib/issues/436) | Cisco Switch | MAC per VLAN empty | Requires VLAN context support |
5151
| [#475](https://github.com/lextudio/sharpsnmplib/issues/475) | Citrix Xen | GetTable timeout | Works in iReasoning, single reads work |
5252

53-
**Note:** Issue #101 also needs the `imported` label added.
54-
5553
## Criteria Used
5654

5755
Issues qualified as "device-related" if they met one or more of these criteria:
@@ -73,7 +71,7 @@ Issues qualified as "device-related" if they met one or more of these criteria:
7371
```bash
7472
gh issue edit 62 --add-label "area:faulty-device"
7573
gh issue edit 89 --add-label "area:faulty-device"
76-
gh issue edit 101 --add-label "area:faulty-device,imported"
74+
gh issue edit 101 --add-label "area:faulty-device"
7775
gh issue edit 370 --add-label "area:faulty-device"
7876
gh issue edit 436 --add-label "area:faulty-device"
7977
gh issue edit 475 --add-label "area:faulty-device"

QUICK_REFERENCE_TAGGING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ gh issue edit 62 --add-label "area:faulty-device"
1111
# Issue #89 - MikroTik unsupported data type 18
1212
gh issue edit 89 --add-label "area:faulty-device"
1313

14-
# Issue #101 - Cisco ASA MsgFlags (also needs 'imported' label)
15-
gh issue edit 101 --add-label "area:faulty-device,imported"
14+
# Issue #101 - Cisco ASA MsgFlags
15+
gh issue edit 101 --add-label "area:faulty-device"
1616

1717
# Issue #370 - QNap NAS GetTable truncation
1818
gh issue edit 370 --add-label "area:faulty-device"

TASK_COMPLETION_SUMMARY.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ ISSUES IDENTIFIED (6 total):
4949

5050
#62 - HP Server - OctetString encoding mismatch
5151
#89 - MikroTik - Unsupported data type 18
52-
#101 - Cisco ASA 5510 - MsgFlags=8 out of range (also needs 'imported' label)
52+
#101 - Cisco ASA 5510 - MsgFlags=8 out of range
5353
#370 - QNap NAS - GetTable truncation issue
5454
#436 - Cisco Switch - MAC address per VLAN support
5555
#475 - Citrix Xen - GetTable timeout issue
@@ -66,7 +66,7 @@ OPTION 1 (Recommended): Run the automated script
6666
OPTION 2: Use GitHub CLI manually
6767
$ gh issue edit 62 --add-label "area:faulty-device"
6868
$ gh issue edit 89 --add-label "area:faulty-device"
69-
$ gh issue edit 101 --add-label "area:faulty-device,imported"
69+
$ gh issue edit 101 --add-label "area:faulty-device"
7070
$ gh issue edit 370 --add-label "area:faulty-device"
7171
$ gh issue edit 436 --add-label "area:faulty-device"
7272
$ gh issue edit 475 --add-label "area:faulty-device"

add-faulty-device-labels.sh

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,8 @@ for issue in "${issues_to_tag[@]}"; do
1919
echo ""
2020
done
2121

22-
# Also add 'imported' label to #101 which is missing it
23-
echo "Adding 'imported' label to issue #101..."
24-
gh issue edit 101 --add-label "imported"
25-
if [ $? -eq 0 ]; then
26-
echo "✓ Successfully added 'imported' label to issue #101"
27-
else
28-
echo "✗ Failed to add 'imported' label to issue #101"
29-
fi
30-
3122
echo ""
3223
echo "Done! All labels have been processed."
3324
echo ""
3425
echo "Summary:"
3526
echo "- Added 'area:faulty-device' label to 6 issues: #62, #89, #101, #370, #436, #475"
36-
echo "- Added 'imported' label to issue #101"

0 commit comments

Comments
 (0)