Skip to content

Commit fb2a6d1

Browse files
committed
Refactor assertions in integration and serialization tests to remove redundant string prefixes
1 parent e49789d commit fb2a6d1

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

Tests/CSharpCore/IntegrationTest.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public async Task TestMessengerSetAsyncV1()
8383
Assert.NotNull(result);
8484
Assert.Single(result);
8585
Assert.Equal("1.3.6.1.2.1.1.5.0", result[0].Id.ToString());
86-
Assert.Equal($"String: {expected}", result[0].Data.ToString());
86+
Assert.Equal(expected, result[0].Data.ToString());
8787
}
8888

8989
[Fact]
@@ -108,7 +108,7 @@ public async Task TestMessengerSetAsyncV2()
108108
Assert.NotNull(result);
109109
Assert.Single(result);
110110
Assert.Equal("1.3.6.1.2.1.1.5.0", result[0].Id.ToString());
111-
Assert.Equal($"String: {expected}", result[0].Data.ToString());
111+
Assert.Equal(expected, result[0].Data.ToString());
112112
}
113113

114114
[Fact]
@@ -596,7 +596,7 @@ public async Task TestMessengerSetAsyncV3_SHA1_AES()
596596
Assert.NotNull(result);
597597
Assert.Single(result);
598598
Assert.Equal("1.3.6.1.2.1.1.5.0", result[0].Id.ToString());
599-
Assert.Equal($"String: {expected}", result[0].Data.ToString());
599+
Assert.Equal(expected, result[0].Data.ToString());
600600
}
601601

602602
[Fact]

Tests/CSharpCore/PrivacyTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public void DecryptEncryptPdu_DES()
7171

7272
var tt = vb.Data.ToString();
7373

74-
Assert.Equal("String: NetSnmpTestContainer", tt);
74+
Assert.Equal("NetSnmpTestContainer", tt);
7575
}
7676

7777
[Fact]
@@ -131,7 +131,7 @@ public void DecryptEncryptPdu_AES()
131131

132132
var tt = vb.Data.ToString();
133133

134-
Assert.Equal("String: NetSnmpTestContainer", tt);
134+
Assert.Equal("NetSnmpTestContainer", tt);
135135
}
136136
}
137137
}

Tests/CSharpCore/SerializationV1Test.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public void DecodeEncodeV1GetRequestMessage()
5858
VersionCode.V1,
5959
message.ProtocolVersion);
6060

61-
Assert.Equal("String: public", message.Community);
61+
Assert.Equal("public", message.Community);
6262

6363
Assert.NotNull(message.Pdu);
6464

@@ -102,7 +102,7 @@ public void DecodeEncodeV1GetResponseMessage()
102102
VersionCode.V1,
103103
message.ProtocolVersion);
104104

105-
Assert.Equal("String: public", message.Community);
105+
Assert.Equal("public", message.Community);
106106

107107
Assert.NotNull(message.Pdu);
108108

@@ -151,7 +151,7 @@ public void DecodeEncodeV1GetNextRequestMessage()
151151
VersionCode.V1,
152152
message.ProtocolVersion);
153153

154-
Assert.Equal("String: public", message.Community);
154+
Assert.Equal("public", message.Community);
155155

156156
Assert.NotNull(message.Pdu);
157157

@@ -195,7 +195,7 @@ public void DecodeEncodeV1GetNextResponseMessage()
195195
VersionCode.V1,
196196
message.ProtocolVersion);
197197

198-
Assert.Equal("String: public", message.Community);
198+
Assert.Equal("public", message.Community);
199199

200200
Assert.NotNull(message.Pdu);
201201

Tests/CSharpCore/SerializationV2Test.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public void DecodeEncodeV2GetRequestMessage()
5959
VersionCode.V2,
6060
message.ProtocolVersion);
6161

62-
Assert.Equal("String: public", message.Community);
62+
Assert.Equal("public", message.Community);
6363

6464
Assert.NotNull(message.Pdu);
6565

@@ -103,7 +103,7 @@ public void DecodeEncodeV2GetResponseMessage()
103103
VersionCode.V2,
104104
message.ProtocolVersion);
105105

106-
Assert.Equal("String: public", message.Community);
106+
Assert.Equal("public", message.Community);
107107

108108
Assert.NotNull(message.Pdu);
109109

@@ -152,7 +152,7 @@ public void DecodeEncodeV2GetNextRequestMessage()
152152
VersionCode.V2,
153153
message.ProtocolVersion);
154154

155-
Assert.Equal("String: public", message.Community);
155+
Assert.Equal("public", message.Community);
156156

157157
Assert.NotNull(message.Pdu);
158158

@@ -196,7 +196,7 @@ public void DecodeEncodeV2GetNextResponseMessage()
196196
VersionCode.V2,
197197
message.ProtocolVersion);
198198

199-
Assert.Equal("String: public", message.Community);
199+
Assert.Equal("public", message.Community);
200200

201201
Assert.NotNull(message.Pdu);
202202

Tests/CSharpCore/TypesEncodeDecode.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public void EncodeDecode_TimeTicks()
100100
var timeTicks = TimeTicks.ReadFrom(reader);
101101
Assert.Equal((uint)394060, timeTicks.Value);
102102
Assert.Equal(hexBer, ToHexString(timeTicks));
103-
Assert.Equal("Timeticks: (394060) 00:01:05:40.60", timeTicks.ToString());
103+
Assert.Equal(TimeSpan.FromMilliseconds(timeTicks.Value * 10).ToString(), timeTicks.ToString());
104104
}
105105
}
106106
}

0 commit comments

Comments
 (0)