Fixing cppcheck comments

Author: lexus2k

src/canvas/canvas.cpp

@@ -666,7 +666,6 @@ void NanoCanvasOps<4>::drawBitmap1(lcdint_t xpos, lcdint_t ypos, lcduint_t w, lc
             }
             else if ( !(m_textMode & CANVAS_MODE_TRANSPARENT) )
             {
-                data = 0x00;
                 m_buf[addr] &= ~(0x0F << BITS_SHIFT4(x));
             }
         }

src/canvas/internal/canvas_types_int.h

@@ -35,7 +35,7 @@
 #ifndef DOXYGEN_SHOULD_SKIP_THIS
 static inline uint8_t pgm_read_byte(const void *ptr)
 {
-    return *((const uint8_t *)ptr);
+    return *reinterpret_cast<const uint8_t*>(ptr);
 }
 #endif
 #endif

src/lcd_hal/arduino/arduino_spi.h

@@ -113,7 +113,7 @@ class ArduinoSpi2
      * @param mosiPin MOSI pin to use, -1 by default
      * @param freq frequency in HZ to run spi bus at
      */
-    ArduinoSpi2(int8_t csPin = -1, int8_t dcPin = -1, int8_t clkPin = -1, int8_t mosiPin = -1, uint32_t freq = 8000000);
+    explicit ArduinoSpi2(int8_t csPin = -1, int8_t dcPin = -1, int8_t clkPin = -1, int8_t mosiPin = -1, uint32_t freq = 8000000);
     ~ArduinoSpi2();
 
     /**

src/lcd_hal/avr/i2c_embedded.cpp

@@ -159,7 +159,7 @@ void SoftwareI2c::start()
     ssd1306_delay(I2C_START_STOP_DELAY);
     DIGITAL_WRITE_LOW(DDR_REG, PORT_REG, m_scl); // Set to LOW
     ssd1306_delay(I2C_HALF_CLOCK);
-    send((m_sa << 1) | 0x00);
+    send(m_sa << 1);
 }
 
 void SoftwareI2c::start(uint8_t sa, bool read_op)

src/lcd_hal/esp/platform.cpp

@@ -111,7 +111,7 @@ void lcd_attachInterrupt(int pin, void (*interrupt)(), int level)
 
 uint8_t lcd_pgmReadByte(const void *ptr)
 {
-    return *((const uint8_t *)ptr);
+    return *reinterpret_cast<const uint8_t *>(ptr);
 }
 
 uint16_t lcd_eepromReadWord(const void *ptr)

src/lcd_hal/linux/linux_i2c.h

@@ -43,7 +43,7 @@ class LinuxI2c
      * @param busId i2c bus number, if -1 defaults to 1
      * @param sa i2c address of the display (7 bits)
      */
-    LinuxI2c(int8_t busId = -1, uint8_t sa = 0x00);
+    explicit LinuxI2c(int8_t busId = -1, uint8_t sa = 0x00);
     ~LinuxI2c();
 
     /**

src/lcd_hal/linux/platform.cpp

@@ -426,7 +426,7 @@ void lcd_attachInterrupt(int pin, void (*interrupt)(void), int level)
 
 uint8_t lcd_pgmReadByte(const void *ptr)
 {
-    return *((const uint8_t *)ptr);
+    return *reinterpret_cast<const uint8_t *>(ptr);
 }
 
 uint16_t lcd_eepromReadWord(const void *ptr)

src/lcd_hal/linux/sdl_i2c.h

@@ -41,7 +41,7 @@ class SdlI2c
      * @param sda pin number to use as data line
      * @param sa i2c address of the display (7 bits)
      */
-    SdlI2c(int8_t scl = -1, int8_t sda = -1, uint8_t sa = 0x00);
+    explicit SdlI2c(int8_t scl = -1, int8_t sda = -1, uint8_t sa = 0x00);
     ~SdlI2c();
 
     /**

src/lcd_hal/mingw/platform.cpp

@@ -66,7 +66,7 @@ void lcd_randomSeed(int seed){};
 void lcd_attachInterrupt(int pin, void (*interrupt)(void), int level){};
 uint8_t lcd_pgmReadByte(const void *ptr)
 {
-    return *((const uint8_t *)ptr);
+    return *reinterpret_cast<const uint8_t *>(ptr);
 };
 uint16_t lcd_eepromReadWord(const void *ptr)
 {

src/lcd_hal/pico/pico_i2c.h

@@ -45,7 +45,7 @@ class PicoI2c
      * @param sda data pin to use for i2c
      * @param sa i2c address of the device to control over i2c
      */
-    PicoI2c(int8_t scl = -1, int8_t sda = -1, uint8_t sa = 0x00);
+    explicit PicoI2c(int8_t scl = -1, int8_t sda = -1, uint8_t sa = 0x00);
     ~PicoI2c();
 
     /**