Feature/create tests refactoring (e2nIEE#2960)

* refactored create tests

* fixed issue in bus_create

* added test placeholders
added some tests

* added missing tests for wards

* added test for create_line

* added tests for create_measurement
updated schema
removed checks in create_measurement when covered by typing
removed forced element_type to bus, there is a raise UserWarning below for this case.

* added test_create_gen

* added tests for create_motor
updated schema to be consisten with create function and other tests

* removed check_existing column and added pd.NA to allowed check

* added trafo create tests

* added create switch test
removed incorrect measurement test

* added create storage test

* added tests for create impedance
fixed issue in create_impedances

* fixed issue in test_create_pwl_costs

* added test_create_poly_costs

* added tests for ext_grid_create

* fixed issue in test_gen_create.py

* added tests for create_group

* added tests for create load

* added tests for create source dc

* fixed issues in vsc_stacked schema
fixed issue in schema validation where a forain bus check would run for custom columns

* fixed schema validation issues in test_line_create.py

* added tests for shunt_create

* fixed call for _bus_index_validation

* added missing tests for sgen create functions

* fixed issues resulting from schema modification

* fixed measurement.side dtype

* cleaned up storage test to reduce code duplication

* cleaned up switch test to reduce code duplication

* fixed types in test_line_create.py

* sonar maintainability improvements.

* fixed all failing tests

* updated pandera version for py3.14 support

* fixed typing version of pandera

* removed float comparison

* removed float comparison

* removed more float comparisons

* removed more float comparisons

* fixed missing import

* fixed more float comparisons

* fixed more float comparisons

* fixed remaining sonar warnings

Author: KS-HTK

pandapower/create/bus_create.py

@@ -320,7 +320,7 @@ def create_buses_dc(
             geo = _geodata_to_geo_series([geodata], coords, nr_buses_dc)
         else:
             assert hasattr(geodata, "__iter__"), "geodata must be an iterable"
-            geo = _geodata_to_geo_series(geodata, coords, nr_buses)  # type: ignore
+            geo = _geodata_to_geo_series(geodata, coords, nr_buses_dc)
     else:
         geo = _geodata_to_geo_series(geodata, coords, nr_buses_dc)
 

pandapower/create/cost_create.py

@@ -104,6 +104,7 @@ def create_pwl_costs(
      - Storage
 
     Parameters:
+        net: the pandapower network
         elements: IDs of the elements in the respective element table
         et: element type, one of "gen", "sgen", "ext_grid", "load", "dcline", "storage"
         points: [[p1, p2, c1], [p2, p3, c2], …] for each element where c(n) defines the costs between p(n) and p(n+1)

pandapower/create/ext_grid_create.py

@@ -7,7 +7,7 @@
 
 import logging
 
-from numpy import nan, bool_
+from numpy import nan
 
 from pandapower.auxiliary import pandapowerNet
 from pandapower.network_structure import get_default_value

pandapower/create/impedance_create.py

@@ -15,6 +15,7 @@
 from pandapower.network_structure import get_default_value
 from pandapower.pp_types import Int
 from pandapower.create._utils import (
+    _add_to_entries_if_not_nan,
     _check_branch_element,
     _check_multiple_branch_elements,
     _get_index_with_check,
@@ -214,7 +215,7 @@ def create_impedances(
     rtf_pu: float | Iterable[float] | None = None,
     xtf_pu: float | Iterable[float] | None = None,
     name: Iterable[str] | None = None,
-    in_service: bool | Iterable[str] = True,
+    in_service: bool | Iterable[bool] = True,
     index: Int | Iterable[Int] | None = None,
     rft0_pu: float | Iterable[float] | None = None,
     xft0_pu: float | Iterable[float] | None = None,
@@ -363,19 +364,20 @@ def create_impedances(
         "in_service": in_service,
         **kwargs,
     }
-    _set_multiple_entries(net, "impedance", index, entries=entries)
 
     if rft0_pu is not None:
-        _set_value_if_not_nan(net, index, rft0_pu, "rft0_pu", "impedance")
-        _set_value_if_not_nan(net, index, xft0_pu, "xft0_pu", "impedance")
-        _set_value_if_not_nan(net, index, rtf0_pu, "rtf0_pu", "impedance")
-        _set_value_if_not_nan(net, index, xtf0_pu, "xtf0_pu", "impedance")
+        _add_to_entries_if_not_nan(net, "impedance", entries, index, "rft0_pu", rft0_pu)
+        _add_to_entries_if_not_nan(net, "impedance", entries, index, "xft0_pu", xft0_pu)
+        _add_to_entries_if_not_nan(net, "impedance", entries, index, "rtf0_pu", rtf0_pu)
+        _add_to_entries_if_not_nan(net, "impedance", entries, index, "xtf0_pu", xtf0_pu)
 
     if gf0_pu is not None:
-        _set_value_if_not_nan(net, index, gf0_pu, "gf0_pu", "impedance")
-        _set_value_if_not_nan(net, index, bf0_pu, "bf0_pu", "impedance")
-        _set_value_if_not_nan(net, index, gt0_pu, "gt0_pu", "impedance")
-        _set_value_if_not_nan(net, index, bt0_pu, "bt0_pu", "impedance")
+        _add_to_entries_if_not_nan(net, "impedance", entries, index, "gf0_pu", gf0_pu)
+        _add_to_entries_if_not_nan(net, "impedance", entries, index, "bf0_pu", bf0_pu)
+        _add_to_entries_if_not_nan(net, "impedance", entries, index, "gt0_pu", gt0_pu)
+        _add_to_entries_if_not_nan(net, "impedance", entries, index, "bt0_pu", bt0_pu)
+
+    _set_multiple_entries(net, "impedance", index, entries=entries)
 
     return index
 

pandapower/create/line_create.py

@@ -814,7 +814,7 @@ def create_lines_from_parameters(
     name: Iterable[str] | None = None,
     index: Int | Iterable[Int] | None = None,
     type: LineType | Iterable[str] | None = None,
-    geodata: Iterable[Iterable[tuple[float, float]]] | None = None,
+    geodata: Iterable[Iterable[tuple[float, float]]] | Iterable[tuple[float, float]] | None = None,
     in_service: bool | Iterable[bool] = get_default_value("line", "in_service"),
     df: float | Iterable[float] = get_default_value("line", "df"),
     parallel: int | Iterable[int] = get_default_value("line", "parallel"),

pandapower/create/measurement_create.py

@@ -26,7 +26,7 @@ def create_measurement(
     std_dev: float,
     element: int,
     side: int | Literal["from", "to"] | Literal["hv", "mv", "lv"] | None = None,
-    check_existing: bool = get_default_value("measurement", "check_existing"),
+    check_existing: bool = False,
     index: Int | None = None,
     name: str | None = None,
     **kwargs,
@@ -36,6 +36,7 @@ def create_measurement(
     are: v, p, q, i, va, ia
 
     Parameters:
+        net: the network to which the measurement will be added
         meas_type: Type of measurement. "v", "p", "q", "i", "va" and "ia" are possible
         element_type: Clarifies which element is measured. "bus", "line", "trafo", "trafo3w", "load", "gen", "sgen",
             "shunt", "ward", "xward" and "ext_grid" are possible
@@ -63,52 +64,20 @@ def create_measurement(
         
         >>> create_measurement(net, "q", "line", 4.5, 0.1, 2, "to")
     """
-    if meas_type not in ("v", "p", "q", "i", "va", "ia"):
-        raise UserWarning(f"Invalid measurement type: {meas_type}")
-
     if side is None and element_type in ("line", "trafo", "trafo3w"):
         raise UserWarning(f"The element type '{element_type}' requires parameter 'side' to be set")
 
-    if meas_type in ("v", "va"):
-        element_type = "bus"
-
-    if element_type not in (
-        "bus",
-        "line",
-        "trafo",
-        "trafo3w",
-        "load",
-        "gen",
-        "sgen",
-        "shunt",
-        "ward",
-        "xward",
-        "ext_grid",
-    ):
-        raise UserWarning(f"Invalid element type: {element_type}")
-
-    if element is not None and element not in net[element_type].index.values:
+    if element is not None and element not in net[element_type].index.to_numpy():
         raise UserWarning(f"{element_type} with index={element} does not exist")
 
-    index = _get_index_with_check(net, "measurement", index)
-
     if meas_type in ("i", "ia") and element_type == "bus":
         raise UserWarning("Line current measurements cannot be placed at buses")
 
-    if meas_type in ("v", "va") and element_type in (
-        "line",
-        "trafo",
-        "trafo3w",
-        "load",
-        "gen",
-        "sgen",
-        "shunt",
-        "ward",
-        "xward",
-        "ext_grid",
-    ):
+    if meas_type in ("v", "va") and element_type != "bus":
         raise UserWarning(f"Voltage measurements can only be placed at a bus, not at {element_type}")
 
+    index = _get_index_with_check(net, "measurement", index)
+
     if check_existing:
         if side is None:
             existing = net.measurement[

pandapower/create/switch_create.py

@@ -139,7 +139,7 @@ def create_switches(
     net: pandapowerNet,
     buses: Sequence,
     elements: Sequence,
-    et: SwitchElementType | Sequence[str],
+    et: SwitchElementType | Sequence[SwitchElementType],
     closed: bool | Iterable[bool] = get_default_value("switch", "closed"),
     type: SwitchType | None = None,
     name: Iterable[str] | None = None,

pandapower/create/trafo_create.py

@@ -99,14 +99,13 @@ def create_transformer(
     Example:
         >>> create_transformer(net, hv_bus=0, lv_bus=1, std_type="0.4 MVA 10/0.4 kV", name="trafo1")
     """
-
     from pandapower.convert_format import convert_trafo_pst_logic
 
+    index = _get_index_with_check(net, "trafo", index, name="transformer")
+
     # Check if bus exist to attach the trafo to
     _check_branch_element(net, "Trafo", index, hv_bus, lv_bus)
 
-    index = _get_index_with_check(net, "trafo", index, name="transformer")
-
     if df <= 0:
         raise ValueError(f"derating factor 'df' must be positive: df = {df:.3f}")
 

pandapower/network_schema/asymmetric_sgen.py

@@ -78,7 +78,7 @@
         "in_service": pa.Column(
             bool, description="specifies if the generator is in service.", metadata={"default": True}
         ),
-        "current_source": pa.Column(bool, description=""),  # TODO: missing in docu
+        #"current_source": pa.Column(bool, description=""),  # TODO: missing in docu and create function
     },
     strict=False,
 )

pandapower/network_schema/measurement.py

@@ -6,7 +6,11 @@
 
 measurement_schema = pa.DataFrameSchema(
     {
-        "name": pa.Column(pd.StringDtype, description="Name of measurement"),
+        "name": pa.Column(
+            pd.StringDtype,
+            nullable=True,
+            description="Name of measurement"
+        ),
         "measurement_type": pa.Column(
             str, pa.Check.isin(["p", "q", "i", "v"]), description="Defines what physical quantity is measured"
         ),
@@ -30,15 +34,11 @@
             int,
             description="If the element_type is “line”, “trafo”, “trafo3w”, “load”, “gen”, “sgen”, “shunt”, “ward”, “xward” or “ext_grid”, element is the index of the relevant element. For “bus” measurements, it is None (default)",
         ),
-        "check_existing": pa.Column(
-            bool,
-            description="Checks if a measurement of the type already exists and overwrites it. If set to False, the measurement may be added twice (unsafe behaviour), but the performance increases",
-            metadata={"default": False},
-        ),  # TODO: shouldn't this be called overwrite?
         "side": pa.Column(
-            str,
+            pd.StringDtype,
+            nullable=True,
             description="Only used for measured lines or transformers. Side defines at which end of the branch the measurement is gathered. For lines this may be “from“, “to“ to denote the side with the from_bus or to_bus. It can also be the index of the from_bus or to_bus. For transformers, it can be “hv“, “mv“ or “lv“ or the corresponding bus index, respectively.",
-        ),  # TODO: check nur wenn element_type trafo oder line
+        ),  # TODO: check nur wenn element_type trafo(3w) oder line
         "origin_id": pa.Column(
             pd.StringDtype, nullable=True, required=False, description="element rdfId from CIM", metadata={"cim": True}
         ),