Skip to content

Commit b049c93

Browse files
committed
Remove continue-on-error so job failures fail the workflow.
The smoke, storage and eve-upgrade jobs no longer ignore step errors, ensuring any failing job marks the whole workflow as failed. To keep all matrix permutations running, each job’s strategy now explicitly sets fail-fast: false. This preserves full test coverage without cancelling siblings early while still surfacing problems in red at the workflow level. Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
1 parent cdd96cb commit b049c93

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ jobs:
5454
fi
5555
5656
smoke:
57-
continue-on-error: true
5857
strategy:
5958
fail-fast: false
6059
matrix:
@@ -133,8 +132,8 @@ jobs:
133132
docker_token: ${{ secrets.DOCKERHUB_PULL_TOKEN }}
134133

135134
storage:
136-
continue-on-error: true
137135
strategy:
136+
fail-fast: false
138137
matrix:
139138
file_system: ['ext4', 'zfs']
140139
name: Storage test suite
@@ -207,8 +206,8 @@ jobs:
207206
docker_token: ${{ secrets.DOCKERHUB_PULL_TOKEN }}
208207

209208
eve-upgrade:
210-
continue-on-error: true
211209
strategy:
210+
fail-fast: false
212211
matrix:
213212
file_system: ['ext4', 'zfs']
214213
name: EVE upgrade test suite

0 commit comments

Comments
 (0)