test(fvt): fix data race in async rule test

- Use mutex to protect 'final' variable update in TestMulShared/async_run
- Fixes flaky test failure where assertion didn't match actual execution order

Signed-off-by: Jiyong Huang <[email protected]>

Author: ngjaying

fvt/rulestate_test.go

@@ -504,21 +504,26 @@ func (s *RuleStateTestSuite) TestMulShared() {
 		wg := sync.WaitGroup{}
 		wg.Add(6)
 		final := 0
+		var mu sync.Mutex
 		go func() {
 			defer wg.Done()
 			fmt.Println("start 1")
 			resp, err := client.StartRule("mul1")
 			s.Require().NoError(err)
 			s.Require().Equal(http.StatusOK, resp.StatusCode)
+			mu.Lock()
 			final = 0
+			mu.Unlock()
 		}()
 		go func() {
 			defer wg.Done()
 			fmt.Println("stop 1")
 			resp, err := client.StopRule("mul1")
 			s.Require().NoError(err)
 			s.Require().Equal(http.StatusOK, resp.StatusCode)
+			mu.Lock()
 			final = 1
+			mu.Unlock()
 		}()
 		go func() {
 			defer wg.Done()
@@ -527,7 +532,9 @@ func (s *RuleStateTestSuite) TestMulShared() {
 			s.Require().NoError(err)
 			s.T().Log(GetResponseText(resp))
 			s.Require().Equal(http.StatusOK, resp.StatusCode)
+			mu.Lock()
 			final = 2
+			mu.Unlock()
 		}()
 		go func() {
 			defer wg.Done()
@@ -536,23 +543,29 @@ func (s *RuleStateTestSuite) TestMulShared() {
 			s.Require().NoError(err)
 			s.T().Log(GetResponseText(resp))
 			s.Require().Equal(http.StatusOK, resp.StatusCode)
+			mu.Lock()
 			final = 3
+			mu.Unlock()
 		}()
 		go func() {
 			defer wg.Done()
 			fmt.Println("stop 2")
 			resp, err := client.StopRule("mul1")
 			s.Require().NoError(err)
 			s.Require().Equal(http.StatusOK, resp.StatusCode)
+			mu.Lock()
 			final = 4
+			mu.Unlock()
 		}()
 		go func() {
 			defer wg.Done()
 			fmt.Println("start 2")
 			resp, err := client.StartRule("mul1")
 			s.Require().NoError(err)
 			s.Require().Equal(http.StatusOK, resp.StatusCode)
+			mu.Lock()
 			final = 5
+			mu.Unlock()
 		}()
 		wg.Wait()
 		metrics, err := client.GetRuleStatus("mul2")