Skip to content

Commit b3a064f

Browse files
OhmSpectatoreriknordmark
authored andcommitted
pillar/zedagent: Revert snapshot capability due to misleading support indication.
Rolling back the reported capability from CAPABILITY_VOLUME_SNAPSHOTS to CAPABILITY_START_DELAY_IN_SECONDS in ReportDeviceInfo. This change addresses the inconsistency where the UI indicated snapshot support in versions prior to its actual implementation. Noted that CAPABILITY_EDGEVIEW, which should technically precede, is commented out in the API proto file. Signed-off-by: Nikolay Martyanov <[email protected]>
1 parent 71b4779 commit b3a064f

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

pkg/pillar/cmd/zedagent/reportinfo.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -614,11 +614,7 @@ func PublishDeviceInfoToZedCloud(ctx *zedagentContext, dest destinationBitset) {
614614

615615
ReportDeviceInfo.State = getState(ctx)
616616

617-
// TODO: Enhance capability reporting with a bitmap-like approach for increased granularity.
618-
// We report the snapshot capability despite the fact that we support snapshots only
619-
// for file-based volumes. If a controller tries to make a snapshot of ZFS-based volume
620-
// device returns a runtime error.
621-
ReportDeviceInfo.ApiCapability = info.APICapability_API_CAPABILITY_VOLUME_SNAPSHOTS
617+
ReportDeviceInfo.ApiCapability = info.APICapability_API_CAPABILITY_START_DELAY_IN_SECONDS
622618

623619
// Report if there is a local override of profile
624620
if ctx.getconfigCtx.currentProfile != ctx.getconfigCtx.globalProfile {

0 commit comments

Comments
 (0)