fiddeling around with constructors

Author: tanneberger

include/reactor-cpp/port.hh

@@ -24,7 +24,7 @@ namespace reactor {
 
 enum class PortType { Input, Output, Delay };
 
-class BasePort : public ReactorElement, public GraphElement { // NOLINT
+class BasePort : public GraphElement, public ReactorElement { // NOLINT
 private:
   BasePort* inward_binding_{nullptr};
   std::set<BasePort*> outward_bindings_{};
@@ -40,6 +40,10 @@ private:
 protected:
   bool present_{false}; // NOLINT cppcoreguidelines-non-private-member-variables-in-classes
 
+  BasePort(const std::string& name, PortType type, Reactor* container)
+      : ReactorElement(name, match_port_enum(type), container)
+      , type_(type) {}
+
   void register_dependency(Reaction* reaction, bool is_trigger) noexcept;
   void register_antidependency(Reaction* reaction) noexcept;
   virtual void cleanup() = 0;
@@ -68,9 +72,6 @@ protected:
   }
 
 public:
-  BasePort(const std::string& name, PortType type, Reactor* container)
-      : ReactorElement(name, match_port_enum(type), container)
-      , type_(type) {}
   ~BasePort() noexcept override = default;
 
   void set_inward_binding(BasePort* port) noexcept { inward_binding_ = port; }
@@ -181,15 +182,15 @@ public:
   Input(const std::string& name, Reactor* container)
       : Port<T>(name, PortType::Input, container) {}
 
-  Input(Input&&) = default; // NOLINT(performance-noexcept-move-constructor)
+  Input(Input&&) noexcept = default; // NOLINT(performance-noexcept-move-constructor)
 };
 
 template <class T> class Output : public Port<T> { // NOLINT
 public:
   Output(const std::string& name, Reactor* container)
       : Port<T>(name, PortType::Output, container) {}
 
-  Output(Output&&) = default; // NOLINT(performance-noexcept-move-constructor)
+  Output(Output&&) noexcept = default; // NOLINT(performance-noexcept-move-constructor)
 };
 
 } // namespace reactor

include/reactor-cpp/reactor_element.hh

@@ -37,7 +37,7 @@ public:
   virtual ~ReactorElement() = default;
 
   // not copyable, but movable
-  ReactorElement(const ReactorElement&) = delete;
+  ReactorElement(const ReactorElement&) = default;
   ReactorElement(ReactorElement&&) = default;
 
   [[nodiscard]] auto container() const noexcept -> Reactor* { return container_; }