Fix clang-tidy configuration and tidy up code

Author: cmnrd

.clang-tidy

@@ -10,205 +10,11 @@ Checks: '
     cppcoreguidelines-*,
     llvm-*,
     cert-*,
-    -clang-analyzer-core.CallAndMessage'
+    -clang-analyzer-core.CallAndMessage,
+    -readability-redundant-member-init'
 WarningsAsErrors: true
 HeaderFilterRegex: ''
-AnalyzeTemporaryDtors: false
 FormatStyle: none
 CheckOptions:
-  - key: cert-dcl16-c.NewSuffixes
-    value: 'L;LL;LU;LLU'
-  - key: cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField
-    value: '0'
-  - key: cppcoreguidelines-avoid-magic-numbers.IgnoredFloatingPointValues
-    value: '1.0;100.0;'
-  - key: cppcoreguidelines-avoid-magic-numbers.IgnoredIntegerValues
-    value: '1;2;3;4;'
-  - key: cppcoreguidelines-explicit-virtual-functions.FinalSpelling
-    value: final
-  - key: cppcoreguidelines-explicit-virtual-functions.IgnoreDestructors
-    value: '1'
-  - key: cppcoreguidelines-explicit-virtual-functions.OverrideSpelling
-    value: override
-  - key: cppcoreguidelines-macro-usage.AllowedRegexp
-    value: '^DEBUG_*'
-  - key: cppcoreguidelines-macro-usage.CheckCapsOnly
-    value: '0'
-  - key: cppcoreguidelines-macro-usage.IgnoreCommandLineMacros
-    value: '1'
-  - key: cppcoreguidelines-no-malloc.Allocations
-    value: '::malloc;::calloc'
-  - key: cppcoreguidelines-no-malloc.Deallocations
-    value: '::free'
-  - key: cppcoreguidelines-no-malloc.Reallocations
-    value: '::realloc'
-  - key: cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
-    value: '1'
-  - key: cppcoreguidelines-owning-memory.LegacyResourceConsumers
-    value: '::free;::realloc;::freopen;::fclose'
-  - key: cppcoreguidelines-owning-memory.LegacyResourceProducers
-    value: '::malloc;::aligned_alloc;::realloc;::calloc;::fopen;::freopen;::tmpfile'
-  - key: cppcoreguidelines-pro-bounds-constant-array-index.GslHeader
-    value: ''
-  - key: cppcoreguidelines-pro-bounds-constant-array-index.IncludeStyle
-    value: 'llvm'
-  - key: cppcoreguidelines-pro-type-member-init.IgnoreArrays
-    value: '0'
-  - key: cppcoreguidelines-pro-type-member-init.UseAssignment
-    value: '0'
-  - key: cppcoreguidelines-special-member-functions.AllowMissingMoveFunctions
-    value: '0'
-  - key: cppcoreguidelines-special-member-functions.AllowSoleDefaultDtor
-    value: '0'
-  - key: google-readability-braces-around-statements.ShortStatementLines
-    value: '1'
-  - key: google-readability-function-size.StatementThreshold
-    value: '800'
-  - key: google-readability-namespace-comments.ShortNamespaceLines
-    value: '10'
-  - key: google-readability-namespace-comments.SpacesBeforeComments
-    value: '2'
-  - key: llvm-namespace-comment.ShortNamespaceLines
-    value: '1'
-  - key: llvm-namespace-comment.SpacesBeforeComments
-    value: '1'
-  - key: modernize-loop-convert.MaxCopySize
-    value: '16'
-  - key: modernize-loop-convert.MinConfidence
-    value: reasonable
-  - key: modernize-loop-convert.NamingStyle
-    value: CamelCase
-  - key: modernize-make-shared.IgnoreMacros
-    value: '1'
-  - key: modernize-make-shared.IncludeStyle
-    value: 'llvm'
-  - key: modernize-make-shared.MakeSmartPtrFunction
-    value: 'std::make_shared'
-  - key: modernize-make-shared.MakeSmartPtrFunctionHeader
-    value: memory
-  - key: modernize-make-unique.IgnoreMacros
-    value: '1'
-  - key: modernize-make-unique.IncludeStyle
-    value: 'llvm'
-  - key: modernize-make-unique.MakeSmartPtrFunction
-    value: 'std::make_unique'
-  - key: modernize-make-unique.MakeSmartPtrFunctionHeader
-    value: memory
-  - key: modernize-pass-by-value.IncludeStyle
-    value: llvm
-  - key: modernize-pass-by-value.ValuesOnly
-    value: '0'
-  - key: modernize-raw-string-literal.ReplaceShorterLiterals
-    value: '0'
-  - key: modernize-replace-auto-ptr.IncludeStyle
-    value: llvm
-  - key: modernize-replace-random-shuffle.IncludeStyle
-    value: llvm
-  - key: modernize-use-auto.MinTypeNameLength
-    value: '5'
-  - key: modernize-use-auto.RemoveStars
-    value: '0'
-  - key: modernize-use-default-member-init.IgnoreMacros
-    value: '1'
-  - key: modernize-use-default-member-init.UseAssignment
-    value: '0'
-  - key: modernize-use-emplace.ContainersWithPushBack
-    value: '::std::vector;::std::list;::std::deque'
-  - key: modernize-use-emplace.SmartPointers
-    value: '::std::shared_ptr;::std::unique_ptr;::std::auto_ptr;::std::weak_ptr'
-  - key: modernize-use-emplace.TupleMakeFunctions
-    value: '::std::make_pair;::std::make_tuple'
-  - key: modernize-use-emplace.TupleTypes
-    value: '::std::pair;::std::tuple'
-  - key: modernize-use-equals-default.IgnoreMacros
-    value: '1'
-  - key: modernize-use-equals-delete.IgnoreMacros
-    value: '1'
-  - key: modernize-use-nodiscard.ReplacementString
-    value: '[[nodiscard]]'
-  - key: modernize-use-noexcept.ReplacementString
-    value: ''
-  - key: modernize-use-noexcept.UseNoexceptFalse
-    value: '1'
-  - key: modernize-use-nullptr.NullMacros
-    value: 'NULL'
-  - key: modernize-use-override.FinalSpelling
-    value: final
-  - key: modernize-use-override.IgnoreDestructors
-    value: '0'
-  - key: modernize-use-override.OverrideSpelling
-    value: override
-  - key: modernize-use-transparent-functors.SafeMode
-    value: '0'
-  - key: modernize-use-using.IgnoreMacros
-    value: '1'
-  - key: performance-faster-string-find.StringLikeClasses
-    value: 'std::basic_string'
-  - key: performance-for-range-copy.AllowedTypes
-    value: ''
-  - key: performance-for-range-copy.WarnOnAllAutoCopies
-    value: '0'
-  - key: performance-inefficient-string-concatenation.StrictMode
-    value: '0'
-  - key: performance-inefficient-vector-operation.VectorLikeClasses
-    value: '::std::vector'
-  - key: performance-move-const-arg.CheckTriviallyCopyableMove
-    value: '1'
-  - key: performance-move-constructor-init.IncludeStyle
-    value: llvm
-  - key: performance-type-promotion-in-math-fn.IncludeStyle
-    value: llvm
-  - key: performance-unnecessary-copy-initialization.AllowedTypes
-    value: ''
-  - key: performance-unnecessary-value-param.AllowedTypes
-    value: ''
-  - key: performance-unnecessary-value-param.IncludeStyle
-    value: llvm
-  - key: portability-simd-intrinsics.Std
-    value: ''
-  - key: portability-simd-intrinsics.Suggest
-    value: '0'
-  - key: readability-braces-around-statements.ShortStatementLines
-    value: '0'
-  - key: readability-function-size.BranchThreshold
-    value: '4294967295'
-  - key: readability-function-size.LineThreshold
-    value: '4294967295'
-  - key: readability-function-size.NestingThreshold
-    value: '4294967295'
-  - key: readability-function-size.ParameterThreshold
-    value: '4294967295'
-  - key: readability-function-size.StatementThreshold
-    value: '800'
-  - key: readability-function-size.VariableThreshold
-    value: '4294967295'
   - key: readability-identifier-length.MinimumParameterNameLength
     value: 2
-  - key: readability-identifier-naming.IgnoreFailedSplit
-    value: '0'
-  - key: readability-implicit-bool-conversion.AllowIntegerConditions
-    value: '0'
-  - key: readability-implicit-bool-conversion.AllowPointerConditions
-    value: '0'
-  - key: readability-inconsistent-declaration-parameter-name.IgnoreMacros
-    value: '1'
-  - key: readability-inconsistent-declaration-parameter-name.Strict
-    value: '0'
-  - key: readability-magic-numbers.IgnoredFloatingPointValues
-    value: '1.0;100.0;'
-  - key: readability-magic-numbers.IgnoredIntegerValues
-    value: '1;2;3;4;'
-  - key: readability-redundant-smartptr-get.IgnoreMacros
-    value: '1'
-  - key: readability-simplify-boolean-expr.ChainedConditionalAssignment
-    value: '0'
-  - key: readability-simplify-boolean-expr.ChainedConditionalReturn
-    value: '0'
-  - key: readability-simplify-subscript-expr.Types
-    value: '::std::basic_string;::std::basic_string_view;::std::vector;::std::array'
-  - key: readability-static-accessed-through-instance.NameSpecifierNestingThreshold
-    value: '3'
-  - key: readability-uppercase-literal-suffix.IgnoreMacros
-    value: '1'
-  - key: readability-uppercase-literal-suffix.NewSuffixes
-    value: ''

examples/power_train/main.cc

@@ -44,7 +44,7 @@ class RightPedal : public Reactor {
   Reaction r1{"1", 1, this, [this]() { reaction_1(); }};
   Reaction r2{"2", 2, this, [this]() { reaction_2(); }};
 
-  void reaction_1(){};
+  void reaction_1() {};
   void reaction_2() {}
 
 public:

include/reactor-cpp/action.hh

@@ -28,8 +28,8 @@ class BaseAction : public ReactorElement {
 private:
   std::set<Reaction*> triggers_{};
   std::set<Reaction*> schedulers_{};
-  const Duration min_delay_{0};
-  const bool logical_{true};
+  Duration min_delay_{0};
+  bool logical_{true};
   bool present_{false};
 
 protected:
@@ -58,12 +58,12 @@ protected:
   BaseAction(const std::string& name, Environment* environment, bool logical, Duration min_delay);
 
 public:
-  [[nodiscard]] auto inline triggers() const noexcept -> const auto& { return triggers_; }
-  [[nodiscard]] auto inline schedulers() const noexcept -> const auto& { return schedulers_; }
-  [[nodiscard]] auto inline is_logical() const noexcept -> bool { return logical_; }
-  [[nodiscard]] auto inline is_physical() const noexcept -> bool { return !logical_; }
-  [[nodiscard]] auto inline min_delay() const noexcept -> Duration { return min_delay_; }
-  [[nodiscard]] auto inline is_present() const noexcept -> bool { return present_; }
+  [[nodiscard]] auto triggers() const noexcept -> const auto& { return triggers_; }
+  [[nodiscard]] auto schedulers() const noexcept -> const auto& { return schedulers_; }
+  [[nodiscard]] auto is_logical() const noexcept -> bool { return logical_; }
+  [[nodiscard]] auto is_physical() const noexcept -> bool { return !logical_; }
+  [[nodiscard]] auto min_delay() const noexcept -> Duration { return min_delay_; }
+  [[nodiscard]] auto is_present() const noexcept -> bool { return present_; }
 
   friend class Reaction;
   friend class Scheduler;
@@ -108,15 +108,15 @@ public:
   auto schedule_at(const ImmutableValuePtr<T>& value_ptr, const Tag& tag) -> bool;
 
   template <class Dur = Duration> void schedule(MutableValuePtr<T>&& value_ptr, Dur delay = Dur::zero()) {
-    schedule(ImmutableValuePtr<T>(std::forward<MutableValuePtr<T>>(value_ptr)), delay);
+    schedule(ImmutableValuePtr<T>(std::move(value_ptr)), delay);
   }
 
   template <class Dur = Duration> void schedule(const T& value, Dur delay = Dur::zero()) {
     schedule(make_immutable_value<T>(value), delay);
   }
 
   template <class Dur = Duration> void schedule(T&& value, Dur delay = Dur::zero()) {
-    schedule(make_immutable_value<T>(std::forward<T>(value)), delay);
+    schedule(make_immutable_value<T>(std::move(value)), delay);
   }
 
   // Scheduling an action with nullptr value is not permitted.
@@ -153,8 +153,8 @@ public:
 
 class Timer : public BaseAction {
 private:
-  const Duration offset_{0};
-  const Duration period_{0};
+  Duration offset_{0};
+  Duration period_{0};
 
   void cleanup() noexcept final;
 

include/reactor-cpp/assert.hh

@@ -34,7 +34,7 @@ constexpr bool runtime_assertion = true;
 
 #ifdef REACTOR_CPP_USE_BACKTRACE
 
-// NOLINTNEXTLINE
+// NOLINTNEXTLINE(llvm-include-order)
 #include REACTOR_CPP_BACKTRACE_HEADER
 #include <array>
 #include <iostream>
@@ -48,7 +48,8 @@ inline void print_backtrace() {
   int size = backtrace(trace.data(), MAX_TRACE_SIZE);
   char** messages = backtrace_symbols(trace.data(), size);
   for (int i{0}; i < size; i++) {
-    std::cerr << "[backtrace] " << messages[i] << '\n'; // NOLINT
+    // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
+    std::cerr << "[backtrace] " << messages[i] << '\n';
   }
 }
 
@@ -70,17 +71,17 @@ public:
       : std::runtime_error(build_message(msg)) {}
 };
 
-constexpr inline void validate([[maybe_unused]] bool condition, [[maybe_unused]] const std::string_view message) {
-  if constexpr (runtime_validation) { // NOLINT
+constexpr void validate([[maybe_unused]] bool condition, [[maybe_unused]] const std::string_view message) {
+  if constexpr (runtime_validation) {
     if (!condition) {
       print_backtrace();
       throw ValidationError(message);
     }
   }
 }
 
-template <typename E> constexpr auto extract_value(E enum_value) -> typename std::underlying_type<E>::type {
-  return static_cast<typename std::underlying_type<E>::type>(enum_value);
+template <typename E> constexpr auto extract_value(E enum_value) -> typename std::underlying_type_t<E> {
+  return static_cast<typename std::underlying_type_t<E>>(enum_value);
 }
 
 void assert_phase([[maybe_unused]] const ReactorElement* ptr, [[maybe_unused]] Phase phase);