Disallow the connection between input and output ports from different containers

Author: byeonggiljun

__tests__/connection.test.ts

@@ -39,6 +39,12 @@ describe("Check canConnect", () => {
           true
         );
       });
+
+      it("canConnect failure", () => {
+        expect(this.canConnect(this.destination.in, this.source.out)).toBe(
+          false
+        );
+      });
     }
   }
   var testApp = new TestApp();

__tests__/hierarchy.ts

@@ -40,20 +40,38 @@ describe("Container to Contained", () => {
     expect(
       app.container.canConnect(app.container.contained.a, app.container.a)
     ).toBe(false);
+    expect(
+      app.container.canConnect(
+        app.container.a,
+        app.container.b
+      )
+    ).toBe(true);
+    expect(
+      app.container.canConnect(
+        app.container.contained.a,
+        app.container.contained.b
+      )
+    ).toBe(false);
     expect(
       app.container.canConnect(
         app.container.contained.b,
         app.container.contained.a
       )
     ).toBe(true);
 
+    expect(
+      app.container.canConnect(app.container.a, app.container.contained.b)
+    ).toBe(false);
     expect(
       app.container.canConnect(app.container.contained.b, app.container.a)
     ).toBe(false);
 
     expect(
       app.container.canConnect(app.container.b, app.container.contained.a)
     ).toBe(false);
+    expect(
+      app.container.canConnect(app.container.contained.a, app.container.b)
+    ).toBe(false);
 
     expect(
       app.container.canConnect(app.container.b, app.container.contained.b)
@@ -65,13 +83,17 @@ describe("Container to Contained", () => {
     expect(app.container.canConnect(app.container.contained.a, app.foo.a)).toBe(
       false
     );
+    expect(app.container.canConnect(app.container.contained.a, app.foo.b)).toBe(
+      false
+    );
     expect(app.container.canConnect(app.foo.a, app.container.contained.a)).toBe(
       false
     );
     expect(app.container.canConnect(app.foo.a, app.container.contained.a)).toBe(
       false
     );
 
+    expect(app.container.canConnect(app.foo.a, app.container.b)).toBe(false);
     expect(app.container.canConnect(app.foo.a, app.container.a)).toBe(false);
 
     // expect(app.container.contained).toBeDefined();

src/core/reactor.ts

@@ -1202,8 +1202,15 @@ export abstract class Reactor extends Component {
         }
       } else {
         // IN to OUT
-        // FIXME: Make this direct feedthrough false after the generated code deletes it.
-        return true;
+        if (
+          src._isContainedBy(this) &&
+          dst !== undefined &&
+          dst._isContainedBy(this)
+        ) {
+          return true;
+        } else {
+          return false;
+        }
       }
     }
   }