Handling overflows and express 'no delay' by undefined

Author: byeonggiljun

src/core/federation.ts

@@ -292,7 +292,6 @@ function isANodeJSCodedError(e: Error): e is NodeJSCodedError {
  * A network sender is a reactor containing a portAbsentReaction.
  */
 export class NetworkSender extends Reactor {
-  
   /**
    * The last reaction of a NetworkSender reactor is the "port absent" reaction.
    * @returns the "port absent" of this reactor
@@ -790,9 +789,9 @@ class RTIClient extends EventEmitter {
    * @param federatePortID The ID of the receiving port.
    */
   public sendRTIPortAbsent(
-    intendedTag: Tag,
     federateID: number,
-    federatePortID: number
+    federatePortID: number,
+    intendedTag: Tag
   ): void {
     const msg = Buffer.alloc(17);
     msg.writeUInt8(RTIMessageTypes.MSG_TYPE_PORT_ABSENT, 0);
@@ -1505,7 +1504,7 @@ export class FederatedApp extends App {
     msg: T,
     destFederateID: number,
     destPortID: number,
-    time: TimeValue
+    time: TimeValue | undefined
   ): void {
     const absTime = this.util.getCurrentTag().getLaterTag(time).toBinary();
     Log.debug(this, () => {
@@ -1597,9 +1596,9 @@ export class FederatedApp extends App {
    * @param destPortID The ID of the receiving port.
    */
   public sendRTIPortAbsent(
-    additionalDelay: TimeValue,
     destFederateID: number,
-    destPortID: number
+    destPortID: number,
+    additionalDelay: TimeValue | undefined
   ): void {
     const intendedTag = this.util.getCurrentTag().getLaterTag(additionalDelay);
     Log.debug(this, () => {
@@ -1609,7 +1608,7 @@ export class FederatedApp extends App {
         )} to federate ID: ${destFederateID}` + ` port ID: ${destPortID}.`
       );
     });
-    this.rtiClient.sendRTIPortAbsent(intendedTag, destFederateID, destPortID);
+    this.rtiClient.sendRTIPortAbsent(destFederateID, destPortID, intendedTag);
   }
 
   /**

src/core/reactor.ts

@@ -1777,9 +1777,9 @@ interface UtilityFunctions {
     time: TimeValue
   ) => void;
   sendRTIPortAbsent: (
-    additionalDealy: TimeValue,
     destFederateID: number,
-    destPortID: number
+    destPortID: number,
+    additionalDelay: TimeValue
   ) => void;
 }
 
@@ -1915,11 +1915,11 @@ export class App extends Reactor {
     }
 
     public sendRTIPortAbsent(
-      additionalDelay: TimeValue,
       destFederateID: number,
-      destPortID: number
+      destPortID: number,
+      additionalDelay: TimeValue
     ): void {
-      this.app.sendRTIPortAbsent(additionalDelay, destFederateID, destPortID);
+      this.app.sendRTIPortAbsent(destFederateID, destPortID, additionalDelay);
     }
   })(this);
 
@@ -2096,9 +2096,9 @@ export class App extends Reactor {
    * @param destPortID The ID of the receiving port.
    */
   protected sendRTIPortAbsent(
-    additionalDelay: TimeValue,
     destFederateID: number,
-    destPortID: number
+    destPortID: number,
+    additionalDelay: TimeValue
   ): void {
     throw new Error(
       "Cannot call sendRTIPortAbsent from an App. sendRTIPortAbsent may be called only from a FederatedApp"

src/core/time.ts

@@ -118,8 +118,18 @@ export class TimeValue {
    * @param other The time value to add to this one.
    */
   add(other: TimeValue): TimeValue {
-    if (other.isNever()) {
-      return this;
+    if (
+      (this.isNever() && other.isForever()) ||
+      (this.isForever() && other.isNever())
+    ) {
+      // The sum of minus infinity and infinity is zero.
+      return TimeValue.zero();
+    } else if (this.isNever() || other.isNever()) {
+      // The sum of minus infinity and a normal tag is minus infinity.
+      return TimeValue.never();
+    } else if (this.isForever() || other.isForever()) {
+      // The sum of infinity and a normal tag is infinity.
+      return TimeValue.forever();
     }
     let seconds = this.seconds + other.seconds;
     let nanoseconds = this.nanoseconds + other.nanoseconds;
@@ -129,7 +139,14 @@ export class TimeValue {
       seconds += 1;
       nanoseconds -= TimeUnit.sec;
     }
-    return TimeValue.secsAndNs(seconds, nanoseconds);
+
+    // Check an overflow.
+    if (!Number.isSafeInteger(seconds)) {
+      // The overflow happens.
+      return TimeValue.forever();
+    } else {
+      return TimeValue.secsAndNs(seconds, nanoseconds);
+    }
   }
 
   /**
@@ -205,6 +222,14 @@ export class TimeValue {
     }
   }
 
+  isForever(): boolean {
+    if (this.seconds === Number.MAX_SAFE_INTEGER && this.nanoseconds === 0) {
+      return true;
+    } else {
+      return false;
+    }
+  }
+
   /**
    * Return true if this time value denotes a time interval of smaller length
    * than the time interval encoded by the time value given as a parameter;
@@ -438,12 +463,15 @@ export class Tag {
    * the given delay. The `microstep` of this time instant is ignored;
    * the returned time instant has a `microstep` of zero if the delay
    * is greater than zero. If the delay equals zero, the tag is returned
-   * unchanged with its current `microstep`.
+   * unchanged with its current `microstep`. If the delay is undefined,
+   * the tag is returned as it was.
    * @param delay The time interval to add to this time instant.
    */
-  getLaterTag(delay: TimeValue): Tag {
-    if (delay.isZero() || delay.isNever()) {
+  getLaterTag(delay: TimeValue | undefined): Tag {
+    if (delay === undefined) {
       return this;
+    } else if (delay.isZero()) {
+      return new Tag(this.time, this.microstep + 1);
     } else {
       return new Tag(delay.add(this.time), 0);
     }