SNAP: setup and translv has wrong location

[certik]

Finding definitions from the main program leads to this location:

Which is the right file and it's almost correct, but it should be 5 lines earlier, the column seems incorrect too.

[dylon]

The location information for translv comes from lfortran:

lfortran --lookup-name --continue-compilation -I. --line=102 --column=32 snap_main.f90 | jq
[
  {
    "kind": 12,
    "location": {
      "range": {
        "start": {
          "character": 29,
          "line": 10
        },
        "end": {
          "character": 22,
          "line": 400
        }
      },
      "uri": "translv.f90"
    },
    "name": "translv",
    "filename": "translv.f90"
  }
]

[certik]

Thanks, made this lfortran/lfortran#5860 (comment).

[Pranavchiku]

MRE:

a.f90

PROGRAM snap_main

  USE setup_module, ONLY: setup
  IMPLICIT NONE
  INTEGER :: ierr, i
  CALL setup ( )

END PROGRAM snap_main

b.f90

MODULE setup_module
  CONTAINS

  SUBROUTINE setup ( )
    INTEGER :: flg, &
      mie

  END SUBROUTINE setup
END MODULE setup_module

% lfortran a.f90 --line=6 --column=9 --lookup-name | jq
[
  {
    "kind": 12,
    "location": {
      "range": {
        "start": {
          "character": 11,
          "line": 4
        },
        "end": {
          "character": 22,
          "line": 8
        }
      },
      "uri": "b.f90"
    },
    "name": "setup",
    "filename": "b.f90"
  }
]

[Pranavchiku]

This is tricky, I am trying to debug we are correctly mapping as well but the highlight is shifted by an offset.

[certik]

I think it's the & in the module. When we save it to a .mod file, and load it, I think we do not correctly take into account the remapping that happens due to the prescanner handling of &.