[pos][native] Fix unit testing setup for pos native tests

Makes below changes to ensure pos native tests run correctly

- Configure the test runner - PrestoSparkRunner - to use hive-admin identity
  so that we are compliant with sql-standard access control.
  Without this, the query result assertions will fail with ACL errors

- Temporarily duplicated utility function 0 HiveTestUtils.getProperty
  to circumvent instantiation of HiveTestUtils class instantiation issues.
  To be fixed in a separate PR

Author: shrinidhijoshi

presto-native-execution/src/test/java/com/facebook/presto/spark/PrestoSparkNativeQueryRunnerUtils.java

@@ -34,11 +34,11 @@
 import java.util.Optional;
 
 import static com.facebook.airlift.log.Level.WARN;
-import static com.facebook.presto.hive.HiveTestUtils.getProperty;
 import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.getNativeWorkerHiveProperties;
 import static com.facebook.presto.nativeworker.NativeQueryRunnerUtils.getNativeWorkerSystemProperties;
 import static com.facebook.presto.nativeworker.PrestoNativeQueryRunnerUtils.getNativeQueryRunnerParameters;
 import static com.facebook.presto.spark.PrestoSparkQueryRunner.METASTORE_CONTEXT;
+import static java.lang.String.format;
 import static java.nio.file.Files.createTempDirectory;
 
 /**
@@ -138,7 +138,7 @@ public static PrestoSparkQueryRunner createRunner(String defaultCatalog, Optiona
         PrestoSparkQueryRunner queryRunner = new PrestoSparkQueryRunner(
                 defaultCatalog,
                 configBuilder.build(),
-                getNativeWorkerHiveProperties(DEFAULT_STORAGE_FORMAT),
+                getNativeWorkerHiveProperties(),
                 additionalSparkProperties,
                 dataDir,
                 nativeModules,
@@ -154,7 +154,10 @@ public static PrestoSparkQueryRunner createRunner(String defaultCatalog, Optiona
     public static QueryRunner createJavaQueryRunner()
             throws Exception
     {
-        return PrestoNativeQueryRunnerUtils.createJavaQueryRunner(Optional.of(getBaseDataPath()), "legacy", DEFAULT_STORAGE_FORMAT, true);
+        return PrestoNativeQueryRunnerUtils.javaHiveQueryRunnerBuilder()
+                .setAddStorageFormatToPath(true)
+                .setStorageFormat(DEFAULT_STORAGE_FORMAT)
+                .build();
     }
 
     public static void customizeLogging()
@@ -201,4 +204,34 @@ public static synchronized Path getBaseDataPath()
         }
         return dataDirectory.get();
     }
+
+    // This is a temporary replacement for the function from
+    // HiveTestUtils.getProperty. But HiveTestUtils instantiation seems to be
+    // failing due to missing info in Hdfs setup. Until we fix that, this is a
+    // copy of that function. As its a simple utility function, we are ok to punt
+    // fixing this
+    // TODO: Use HiveTestUtils.getProperty and delete this function
+    public static Optional<String> getProperty(String name)
+    {
+        String systemPropertyValue = System.getProperty(name);
+        String environmentVariableValue = System.getenv(name);
+        if (systemPropertyValue == null) {
+            if (environmentVariableValue == null) {
+                return Optional.empty();
+            }
+            else {
+                return Optional.of(environmentVariableValue);
+            }
+        }
+        else {
+            if (environmentVariableValue != null && !systemPropertyValue.equals(environmentVariableValue)) {
+                throw new IllegalArgumentException(format("%s is set in both Java system property and environment variable, but their values are different. The Java system property value is %s, while the" +
+                                " environment variable value is %s. Please use only one value.",
+                        name,
+                        systemPropertyValue,
+                        environmentVariableValue));
+            }
+            return Optional.of(systemPropertyValue);
+        }
+    }
 }

presto-spark-base/pom.xml

@@ -69,7 +69,10 @@
             <groupId>com.facebook.presto</groupId>
             <artifactId>presto-main-base</artifactId>
         </dependency>
-
+        <dependency>
+            <groupId>com.facebook.presto</groupId>
+            <artifactId>presto-main</artifactId>
+        </dependency>
         <dependency>
             <groupId>com.facebook.presto</groupId>
             <artifactId>presto-expressions</artifactId>

presto-spark-base/src/test/java/com/facebook/presto/spark/PrestoSparkQueryRunner.java

@@ -63,6 +63,7 @@
 import com.facebook.presto.spi.WarningCollector;
 import com.facebook.presto.spi.eventlistener.EventListener;
 import com.facebook.presto.spi.function.FunctionImplementationType;
+import com.facebook.presto.spi.security.Identity;
 import com.facebook.presto.spi.security.PrincipalType;
 import com.facebook.presto.split.PageSourceManager;
 import com.facebook.presto.split.SplitManager;
@@ -330,6 +331,12 @@ public PrestoSparkQueryRunner(
         defaultSession = testSessionBuilder(injector.getInstance(SessionPropertyManager.class))
                 .setCatalog(defaultCatalog)
                 .setSchema("tpch")
+                // Sql-Standard Access Control Checker
+                // needs us to specify our role
+                .setIdentity(new Identity(
+                        "hive",
+                        Optional.empty(),
+                        ImmutableMap.of(defaultCatalog, "admin")))
                 .build();
 
         transactionManager = injector.getInstance(TransactionManager.class);