Fix NPE in IcebergHiveMetadata.getViews when the provided schema is null

BryanCutler · Presto CUDF CI · commit b6d3fca6e934 · 2025-09-08T11:45:53.000Z
diff --git a/presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergHiveMetadata.java b/presto-iceberg/src/main/java/com/facebook/presto/iceberg/IcebergHiveMetadata.java
@@ -475,9 +475,8 @@ public Map<SchemaTableName, ConnectorViewDefinition> getViews(ConnectorSession s
             tableNames = ImmutableList.of(new SchemaTableName(prefix.getSchemaName(), prefix.getTableName()));
         }
         else {
-            tableNames = listViews(session, Optional.of(prefix.getSchemaName()));
+            tableNames = listViews(session, Optional.ofNullable(prefix.getSchemaName()));
         }
-        MetastoreContext metastoreContext = getMetastoreContext(session);
         for (SchemaTableName schemaTableName : tableNames) {
             Optional<Table> table = getHiveTable(session, schemaTableName);
             if (table.isPresent() && isPrestoView(table.get())) {

Original file line number	Diff line number	Diff line change
`@@ -475,9 +475,8 @@ public Map<SchemaTableName, ConnectorViewDefinition> getViews(ConnectorSession s`
`475`	`475`	`tableNames = ImmutableList.of(new SchemaTableName(prefix.getSchemaName(), prefix.getTableName()));`
`476`	`476`	`}`
`477`	`477`	`else {`
`478`		`- tableNames = listViews(session, Optional.of(prefix.getSchemaName()));`
	`478`	`+ tableNames = listViews(session, Optional.ofNullable(prefix.getSchemaName()));`
`479`	`479`	`}`
`480`		`- MetastoreContext metastoreContext = getMetastoreContext(session);`
`481`	`480`	`for (SchemaTableName schemaTableName : tableNames) {`
`482`	`481`	`Optional<Table> table = getHiveTable(session, schemaTableName);`
`483`	`482`	`if (table.isPresent() && isPrestoView(table.get())) {`