Skip to content

Commit 7f07c5f

Browse files
committed
Fix pugi?
Signed-off-by: Larry Gritz <lg@larrygritz.com>
1 parent a417805 commit 7f07c5f

File tree

2 files changed

+21
-19
lines changed

2 files changed

+21
-19
lines changed

src/build-scripts/build_openexr.bash

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ pwd
2727
echo "Building OpenEXR ${OPENEXR_VERSION}"
2828
echo "OpenEXR build dir will be: ${OPENEXR_BUILD_DIR}"
2929
echo "OpenEXR install dir will be: ${OPENEXR_INSTALL_DIR}"
30-
echo "OpenEXR Build type is ${OPENEXR_BUILD_TYPE}"
30+
echo "OpenEXR build type is ${OPENEXR_BUILD_TYPE}"
3131
echo "CMAKE_PREFIX_PATH is ${CMAKE_PREFIX_PATH}"
3232

3333
# Clone OpenEXR project (including Imath) from GitHub and build
@@ -37,11 +37,11 @@ if [[ ! -e ${OPENEXR_SOURCE_DIR} ]] ; then
3737
fi
3838
mkdir -p ${OPENEXR_INSTALL_DIR} && true
3939

40-
pushd ${OPENEXR_SOURCE_DIR}
40+
pushd ${LOCAL_DEPS_DIR}
4141
git checkout ${OPENEXR_VERSION} --force
4242
echo "Building OpenEXR from commit" `git rev-parse --short HEAD`
4343

44-
cmake -S . -B ${OPENEXR_BUILD_DIR} \
44+
cmake -S ${OPENEXR_SOURCE_DIR} -B ${OPENEXR_BUILD_DIR} \
4545
-DCMAKE_BUILD_TYPE=${OPENEXR_BUILD_TYPE} \
4646
-DCMAKE_INSTALL_PREFIX="${OPENEXR_INSTALL_DIR}" \
4747
-DCMAKE_PREFIX_PATH="${CMAKE_PREFIX_PATH}" \

src/build-scripts/build_pugixml.bash

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -13,38 +13,40 @@ set -ex
1313
PUGIXML_REPO=${PUGIXML_REPO:=https://github.com/zeux/pugixml.git}
1414
PUGIXML_VERSION=${PUGIXML_VERSION:=v1.11.4}
1515

16-
# Where to put pugixml repo source (default to the ext area)
17-
PUGIXML_SRC_DIR=${PUGIXML_SRC_DIR:=${PWD}/ext/pugixml}
18-
# Temp build area (default to a build/ subdir under source)
19-
PUGIXML_BUILD_DIR=${PUGIXML_BUILD_DIR:=${PUGIXML_SRC_DIR}/build}
20-
# Install area for pugixml (default to ext/dist)
2116
LOCAL_DEPS_DIR=${LOCAL_DEPS_DIR:=${PWD}/ext}
17+
PUGIXML_SOURCE_DIR=${PUGIXML_SOURCE_DIR:=${LOCAL_DEPS_DIR}/pugixml}
18+
PUGIXML_BUILD_DIR=${PUGIXML_BUILD_DIR:=${PUGIXML_SOURCE_DIR}/build}
2219
PUGIXML_INSTALL_DIR=${PUGIXML_INSTALL_DIR:=${LOCAL_DEPS_DIR}/dist}
23-
#PUGIXML_BUILD_OPTS=${PUGIXML_BUILD_OPTS:=}
20+
PUGIXML_BUILD_TYPE=${PUGIXML_BUILD_TYPE:=${CMAKE_BUILD_TYPE:-Release}}
2421

2522
pwd
26-
echo "pugixml install dir will be: ${PUGIXML_INSTALL_DIR}"
23+
echo "Building Pugixml ${PUGIXML_VERSION}"
24+
echo "Pugixml build dir will be: ${PUGIXML_BUILD_DIR}"
25+
echo "Pugixml install dir will be: ${PUGIXML_INSTALL_DIR}"
26+
echo "Pugixml build type is ${PUGIXML_BUILD_TYPE}"
27+
echo "CMAKE_PREFIX_PATH is ${CMAKE_PREFIX_PATH}"
2728

28-
mkdir -p ./ext
29-
pushd ./ext
29+
mkdir -p ${LOCAL_DEPS_DIR}
3030

3131
# Clone pugixml project from GitHub and build
32-
if [[ ! -e ${PUGIXML_SRC_DIR} ]] ; then
33-
echo "git clone ${PUGIXML_REPO} ${PUGIXML_SRC_DIR}"
34-
git clone ${PUGIXML_REPO} ${PUGIXML_SRC_DIR}
32+
if [[ ! -e ${PUGIXML_SOURCE_DIR} ]] ; then
33+
echo "git clone ${PUGIXML_REPO} ${PUGIXML_SOURCE_DIR}"
34+
git clone ${PUGIXML_REPO} ${PUGIXML_SOURCE_DIR}
3535
fi
36-
cd ${PUGIXML_SRC_DIR}
36+
mkdir -p ${PUGIXML_INSTALL_DIR} && true
3737

38+
pushd ${LOCAL_DEPS_DIR}
3839
echo "git checkout ${PUGIXML_VERSION} --force"
3940
git checkout ${PUGIXML_VERSION} --force
4041
echo "Building pugixml from commit" `git rev-parse --short HEAD`
4142

4243
if [[ -z $DEP_DOWNLOAD_ONLY ]]; then
43-
time cmake -S . -B ${PUGIXML_BUILD_DIR} -DCMAKE_BUILD_TYPE=Release \
44+
time cmake -S ${PUGIXML_SOURCE_DIR} -B ${PUGIXML_BUILD_DIR} \
45+
-DCMAKE_BUILD_TYPE=${PUGIXML_BUILD_TYPE} \
4446
-DCMAKE_INSTALL_PREFIX=${PUGIXML_INSTALL_DIR} \
45-
-DBUILD_SHARED_LIBS=ON \
47+
-DBUILD_SHARED_LIBS=${PUGIXML_LOCAL_BUILD_SHARED_LIBS:=ON} \
4648
-DBUILD_TESTS=OFF \
47-
${PUGIXML_BUILD_OPTS} ..
49+
${PUGIXML_CMAKE_FLAGS}
4850
time cmake --build ${PUGIXML_BUILD_DIR} --config Release --target install
4951
fi
5052

0 commit comments

Comments
 (0)