Merge pull request #1 from lhellemons/bugfix/value-object-superclass-constructor

ValueObjectTrait constructor bugfix

Author: lhellemons

src/Value/ValueObjectTrait.php

@@ -24,8 +24,6 @@ trait ValueObjectTrait
     /** @var Ref[] */
     static private $instances = [];
 
-    abstract protected function __construct(...$arguments);
-
     final protected static function getInstance(...$values): self
     {
         $key = calculateKey(static::class, ...$values);

test/Value/ValueObjectTraitTest.php

@@ -57,6 +57,16 @@ public function testInheritance(): void
         $this->assertNotSame($subclassB11,$subclassC11);
     }
 
+    public function testInheritanceWithoutParentConstructor(): void
+    {
+        try {
+            SubclassWithConstructorType::fromFoo('1');
+            $this->expectNotToPerformAssertions();
+        } catch (\Throwable $e) {
+            $this->fail(sprintf('Unable to instantiate value object subclass without parent constructor: %s', $e));
+        }
+    }
+
     public function testNoMutation(): void
     {
         $testObject = FromValuesType::fromFooAndBar('foo', 1);
@@ -136,8 +146,8 @@ public function getCasesForValueTypes(): array
         $stdClassB = new \stdClass();
         $stdClassB->foo = 'bar';
 
-        $objectA = new Object();
-        $objectB = new Object();
+        $objectA = new ObjectClass();
+        $objectB = new ObjectClass();
 
         $resourceA = fopen(__DIR__ . '/test_resource', 'r');
         $resourceB = fopen(__DIR__ . '/test_resource', 'r');
@@ -227,7 +237,7 @@ public function getValue()
     }
 }
 
-class Object {}
+class ObjectClass {}
 
 class FromValuesType
 {
@@ -363,3 +373,31 @@ public function getBarC(): int
         return $this->barC;
     }
 }
+
+
+
+abstract class SuperclassWithoutConstructorType
+{
+    use ValueObjectTrait;
+}
+
+class SubclassWithConstructorType extends SuperclassWithoutConstructorType
+{
+    /** @var string */
+    private $foo;
+
+    protected function __construct(string $foo)
+    {
+        $this->foo = $foo;
+    }
+
+    public static function fromFoo(string $foo): self
+    {
+        return self::getInstance($foo);
+    }
+
+    public function getFoo(): string
+    {
+        return $this->foo;
+    }
+}