Merge pull request #3193 from liam-hq/devin/1753856803-consolidate-hasToolCalls

refactor: consolidate hasToolCalls function into shared utility

Author: junkisai

frontend/internal-packages/agent/src/db-agent/routing/routeAfterDesignSchema.ts

@@ -1,5 +1,5 @@
-import type { BaseMessage } from '@langchain/core/messages'
 import type { WorkflowState } from '../../chat/workflow/types'
+import { hasToolCalls } from '../../utils/hasToolCalls'
 
 /**
  * Determines the next node based on whether the last message contains tool calls
@@ -16,14 +16,3 @@ export const routeAfterDesignSchema = (
 
   return 'generateTestcase'
 }
-
-/**
- * Checks if a message contains tool calls
- */
-const hasToolCalls = (message: BaseMessage): boolean => {
-  return (
-    'tool_calls' in message &&
-    Array.isArray(message.tool_calls) &&
-    message.tool_calls.length > 0
-  )
-}

frontend/internal-packages/agent/src/pm-agent/routing/routeAfterAnalyzeRequirements.ts

@@ -1,5 +1,5 @@
-import type { BaseMessage } from '@langchain/core/messages'
 import { WorkflowTerminationError } from '../../shared/errorHandling'
+import { hasToolCalls } from '../../utils/hasToolCalls'
 import type { PmAgentState } from '../pmAgentAnnotations'
 
 const MAX_ANALYSIS_RETRY_COUNT = 3
@@ -39,14 +39,3 @@ export const routeAfterAnalyzeRequirements = (
   // 4. No tool calls and requirements not set -> re-analyze
   return 'analyzeRequirements'
 }
-
-/**
- * Checks if a message contains tool calls
- */
-const hasToolCalls = (message: BaseMessage): boolean => {
-  return (
-    'tool_calls' in message &&
-    Array.isArray(message.tool_calls) &&
-    message.tool_calls.length > 0
-  )
-}

frontend/internal-packages/agent/src/utils/hasToolCalls.ts

@@ -0,0 +1,14 @@
+import type { BaseMessage } from '@langchain/core/messages'
+
+/**
+ * Check if a message contains tool calls
+ * @param message - The BaseMessage to check
+ * @returns true if the message has non-empty tool_calls array
+ */
+export const hasToolCalls = (message: BaseMessage): boolean => {
+  return (
+    'tool_calls' in message &&
+    Array.isArray(message.tool_calls) &&
+    message.tool_calls.length > 0
+  )
+}