Add to_json* / from_json* Deprecation Warnings #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etscrivner
force-pushed
the
add-deprecation-warning-on-to_json-methods
branch
from
6952eb5 to
f7a9c01
Compare
Addresses the first half of lian#267 Add deprecation warnings to all `to_json*` and `from_json*` methods to indicate that these will be removed in a future release. All deprecated methods are also moved to be near each other so they will be easier to remove in the future. This causes the tests to display a lot of warnings and the tests and examples using these methods must also be removed / revised once they are gone for good.
etscrivner
force-pushed
the
add-deprecation-warning-on-to_json-methods
branch
from
f7a9c01 to
9af290f
Compare
etscrivner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the first half of #267
Add deprecation warnings on
Bitcoin::Protocol::Tx#to_json(_file)as well asto
Bitcoin::Protocol::Block#to_json(_file).This causes the tests to display a lot of warnings and the tests and examples
using these methods must also be removed / revised once they are gone for good.