fix: address additional CodeRabbit review comments

- Fix dry-run file count to report actual file count regardless of mode
- Add explicit UTF-8 encoding when writing generated files
- Fix single-element tuple in test detection_dirs
- Move prompts directory from packages to force-include in pyproject.toml

Author: ryderstorm

pyproject.toml

@@ -36,11 +36,12 @@ spec-driven-development-mcp = "server:main"
 sdd-generate-commands = "slash_commands.cli:main"
 
 [tool.hatch.build.targets.wheel]
-packages = ["mcp_server", "prompts", "slash_commands"]
+packages = ["mcp_server", "slash_commands"]
 
 [tool.hatch.build.targets.wheel.force-include]
 "server.py" = "server.py"
 "__version__.py" = "__version__.py"
+"prompts/" = "prompts/"
 
 
 # --- Ruff (linter + formatter) ---

slash_commands/writer.py

@@ -120,7 +120,7 @@ def generate(self) -> dict[str, Any]:
 
         return {
             "prompts_loaded": len(prompts),
-            "files_written": sum(1 for f in files if not self.dry_run),
+            "files_written": len(files),
             "files": files,
             "prompts": [{"name": p.name, "path": str(p.path)} for p in prompts],
             "backups_created": self._backups_created,
@@ -178,7 +178,7 @@ def _generate_file(self, prompt: MarkdownPrompt, agent: AgentConfig) -> dict[str
 
         # Write file if not dry run
         if not self.dry_run:
-            output_path.write_text(content)
+            output_path.write_text(content, encoding="utf-8")
 
         return {
             "path": str(output_path),

tests/test_cli.py

@@ -316,7 +316,7 @@ def test_cli_interactive_agent_selection_selects_all(mock_prompts_dir, tmp_path)
                 command_dir=".cursor/commands",
                 command_format=CommandFormat.MARKDOWN,
                 command_file_extension=".md",
-                detection_dirs=(".cursor"),
+                detection_dirs=(".cursor",),
             ),
         ]