Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Commit 2743a62

Browse files
committed
pass cflags to msvc before source files in command line options
1 parent 7772802 commit 2743a62

File tree

4 files changed

+34
-15
lines changed

4 files changed

+34
-15
lines changed

.github/workflows/release.yml

Lines changed: 25 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ on:
44
tags:
55
- 'v*'
66

7+
defaults:
8+
run:
9+
shell: bash
10+
711
jobs:
812
build-lib:
913
name: build lib file (target = ${{ matrix.build.target }})
@@ -61,13 +65,13 @@ jobs:
6165
target: ${{ matrix.build.target }}
6266
override: true
6367

64-
- name: install ruby
65-
uses: ruby/setup-ruby@v1
66-
with:
67-
ruby-version: "3.1.1"
68-
69-
- name: print rustc detailed version
70-
run: rustc --version --verbose
68+
- name: print system info
69+
run: |
70+
rustc --version --verbose
71+
which make
72+
make --version
73+
which bash
74+
bash --version
7175
7276
- name: checkout
7377
uses: actions/checkout@v2
@@ -90,8 +94,21 @@ jobs:
9094
name: ${{ matrix.build.output_artifact_name }}
9195
path: ${{ matrix.build.output_artifact_name }}
9296

97+
- name: download benchmark assets
98+
run: make benchmark/download
99+
100+
- name: build C runner
101+
run: make benchmark/c-parser
102+
103+
# NOTE: ruby/setup-ruby breaks paths for MSVC,
104+
# and so all files must be compiled before running Ruby
105+
- name: install ruby
106+
uses: ruby/setup-ruby@v1
107+
with:
108+
ruby-version: "3.1.1"
109+
93110
- name: benchmark
94-
run: make benchmark/download && make benchmark/record
111+
run: make benchmark/record
95112

96113
- name: upload ${{ matrix.build.target }}.benchmark-out
97114
uses: actions/upload-artifact@v2

.github/workflows/test.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,13 @@ jobs:
9696
target: ${{ matrix.build.target }}
9797
override: true
9898

99-
- name: print rustc detailed version
100-
run: rustc --version --verbose
99+
- name: print system info
100+
run: |
101+
rustc --version --verbose
102+
which make
103+
make --version
104+
which bash
105+
bash --version
101106
102107
- name: checkout
103108
uses: actions/checkout@v2

Makefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,6 @@ clean:
6565
rm -rf *.dSYM
6666
touch codegen/build.rs
6767

68-
check:
69-
CC=$(CC) ruby assert_defs.rb bindings.h bindings.c bindings_messages.c bindings_nodes.c
70-
7168
doxygen: messages.h nodes.h token_ids.h
7269
rm -rf docs
7370
doxygen

scripts/targets/x86_64-pc-windows-msvc.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ lib.exe $(1) $(2) /OUT:$(1)
2020
endef
2121

2222
define build_c_obj
23-
$(CC) $(1) $(CFLAGS) /c /Fo
23+
$(CC) /c $(CFLAGS) /Fo $(1)
2424
endef
2525

2626
define build_c_exe
27-
$(CC) ws2_32.lib advapi32.lib userenv.lib bcrypt.lib $(1) $(CFLAGS) /link /OUT:$(2)
27+
$(CC) $(CFLAGS) ws2_32.lib advapi32.lib userenv.lib bcrypt.lib $(1) /link /OUT:$(2)
2828
endef
2929

3030
BENCHMARK_RUNNER_ASSET_NAME = rust-parser-x86_64-pc-windows-msvc.exe

0 commit comments

Comments
 (0)