get rid of default ctors

Author: iliabylich

lib-ruby-parser-cpp-bindings/gen/cpp/nodes/classes_cpp.rs

@@ -44,14 +44,12 @@ impl<'a> NodeImplementation<'a> {
 
     fn code(&self) -> String {
         format!(
-            "{class_name}::{class_name}({args})
-{{
-{constructor}
-}}
+            "{class_name}::{class_name}({args}):
+    {member_initializer_list} {{}}
 ",
             class_name = self.node.struct_name,
             args = self.args().join(", "),
-            constructor = self.construtor_stmts().join("\n")
+            member_initializer_list = self.member_initializer_list().join(",\n    ")
         )
     }
 
@@ -65,7 +63,7 @@ impl<'a> NodeImplementation<'a> {
         })
     }
 
-    fn construtor_stmts(&self) -> Vec<String> {
+    fn member_initializer_list(&self) -> Vec<String> {
         map_node_fields(&self.node.fields, |f| {
             let field_name = Field::new(f).cpp_name();
 
@@ -74,11 +72,7 @@ impl<'a> NodeImplementation<'a> {
                 rhs = format!("std::move({})", rhs)
             }
 
-            format!(
-                "this->{field_name} = {rhs};",
-                field_name = field_name,
-                rhs = rhs
-            )
+            format!("{field_name}({rhs})", field_name = field_name, rhs = rhs)
         })
     }
 }

src/bytes.cpp

@@ -14,13 +14,6 @@ namespace lib_ruby_parser
         return result;
     }
 
-    Bytes::Bytes()
-    {
-        this->size_ = 0;
-        this->bytes_ = nullptr;
-        this->borrowed = false;
-    }
-
     Bytes::~Bytes()
     {
         if (borrowed)

src/bytes.h

@@ -15,7 +15,6 @@ namespace lib_ruby_parser
         bool borrowed = false;
 
     public:
-        Bytes();
         ~Bytes();
 
         explicit Bytes(std::string s);

src/custom_decoder.cpp

@@ -4,19 +4,16 @@
 
 namespace lib_ruby_parser
 {
+    CustomDecoder::Result::Result(Bytes output) : data(std::move(output)){};
+    CustomDecoder::Result::Result(std::string error_message) : data(std::move(error_message)){};
+
     CustomDecoder::Result CustomDecoder::Result::Ok(Bytes output)
     {
-        CustomDecoder::Result result;
-        result.success = true;
-        result.output = std::move(output);
-        return result;
+        return CustomDecoder::Result(std::move(output));
     }
 
     CustomDecoder::Result CustomDecoder::Result::Error(std::string error_message)
     {
-        CustomDecoder::Result result;
-        result.success = false;
-        result.error_message = std::move(error_message);
-        return result;
+        return CustomDecoder::Result(std::move(error_message));
     }
 } // namespace lib_ruby_parser

src/custom_decoder.h

@@ -3,6 +3,7 @@
 
 #include <string>
 #include <vector>
+#include <variant>
 #include "bytes.h"
 
 namespace lib_ruby_parser
@@ -13,11 +14,11 @@ namespace lib_ruby_parser
         class Result
         {
         public:
-            bool success;
-            Bytes output;
-            std::string error_message;
+            std::variant<Bytes, std::string> data;
 
-            Result() = default;
+            Result() = delete;
+            explicit Result(Bytes output);
+            explicit Result(std::string error_message);
             Result(Result &&) = default;
             Result(const Result &) = delete;