Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Commit dd61ea9

Browse files
committed
removed all 'using namespace' calls
1 parent 5dd769b commit dd61ea9

File tree

3 files changed

+118
-126
lines changed

3 files changed

+118
-126
lines changed

build-convert/build.rs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ fn relative_path(path: &str) -> String {
1515

1616
fn build_comparison(node: &Node) -> String {
1717
format!(
18-
"if constexpr (std::is_same_v<T, std::unique_ptr<{class_name}>>)
18+
"if constexpr (std::is_same_v<T, std::unique_ptr<lib_ruby_parser::{class_name}>>)
1919
return convert(std::move(inner), env);",
2020
class_name = node.struct_name
2121
)
@@ -43,7 +43,7 @@ fn build_converter(node: &Node) -> String {
4343
.collect();
4444

4545
format!(
46-
"Napi::Value convert(std::unique_ptr<{class_name}> node, Napi::Env env) {{
46+
"Napi::Value convert(std::unique_ptr<lib_ruby_parser::{class_name}> node, Napi::Env env) {{
4747
if (!node) {{
4848
return env.Null();
4949
}}
@@ -118,18 +118,16 @@ fn main() {
118118
#include <iostream>
119119
#include \"lib-ruby-parser.h\"
120120
121-
using namespace lib_ruby_parser;
122-
123121
template<class> inline constexpr bool always_false_v = false;
124122
125123
namespace lib_ruby_parser_node
126124
{{
127125
{ctor_definitions}
128126
{ctor_fn_definitions}
129127
130-
Napi::Value convert(std::unique_ptr<Node> node, Napi::Env env);
131-
Napi::Value convert(Node node, Napi::Env env);
132-
Napi::Value convert(std::unique_ptr<Range> range, Napi::Env env);
128+
Napi::Value convert(std::unique_ptr<lib_ruby_parser::Node> node, Napi::Env env);
129+
Napi::Value convert(lib_ruby_parser::Node node, Napi::Env env);
130+
Napi::Value convert(std::unique_ptr<lib_ruby_parser::Range> range, Napi::Env env);
133131
134132
Napi::Value convert(std::string s, Napi::Env env)
135133
{{
@@ -141,7 +139,7 @@ namespace lib_ruby_parser_node
141139
return Napi::Number::New(env, 0);
142140
}}
143141
144-
Napi::Value convert(std::vector<Node> nodes, Napi::Env env)
142+
Napi::Value convert(std::vector<lib_ruby_parser::Node> nodes, Napi::Env env)
145143
{{
146144
Napi::Array arr = Napi::Array::New(env, nodes.size());
147145
for (size_t i = 0; i < nodes.size(); i++)
@@ -153,7 +151,7 @@ namespace lib_ruby_parser_node
153151
154152
{converters}
155153
156-
Napi::Value convert(std::unique_ptr<Node> node, Napi::Env env)
154+
Napi::Value convert(std::unique_ptr<lib_ruby_parser::Node> node, Napi::Env env)
157155
{{
158156
if (!node) {{
159157
return env.Null();
@@ -166,7 +164,7 @@ namespace lib_ruby_parser_node
166164
}}, node->inner);
167165
}}
168166
169-
Napi::Value convert(Node node, Napi::Env env)
167+
Napi::Value convert(lib_ruby_parser::Node node, Napi::Env env)
170168
{{
171169
return std::visit([env](auto &&inner) {{
172170
using T = std::decay_t<decltype(inner)>;

0 commit comments

Comments
 (0)