Skip to content

Commit 0202bc9

Browse files
committed
attempt to induce timeout in mpi restart by undoing inconsistent step size fix
1 parent be1ce60 commit 0202bc9

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

pymatnext/ns.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def init_configs(self, params_configs, configs_file=None, extra=False):
209209
raise RuntimeError(f"Got too many configs (expected {self.n_configs_global}) from new config generator {new_configs_generator}")
210210

211211
# Check that all step sizes are the same. Maybe instead we should just copy from first?
212-
assert new_config.step_size == first_config.step_size, f"Mismatched step size for config {config_i} {new_config.step_size} != 0 {first_config.step_size}" #NB
212+
#NB assert new_config.step_size == first_config.step_size, f"Mismatched step size for config {config_i} {new_config.step_size} != 0 {first_config.step_size}"
213213

214214
target_rank = config_i // self.max_n_configs_local
215215
if target_rank == self.comm.rank:
@@ -383,8 +383,8 @@ def step_size_tune(self, n_configs=1, min_accept_rate=0.25, max_accept_rate=0.5,
383383
for ns_config in self.local_configs:
384384
ns_config.step_size = new_step_size
385385
# make sure that config used as buffer also has correct step_size
386-
if self.extra_config: #NB
387-
self.extra_config.step_size = new_step_size #NB
386+
#NB if self.extra_config:
387+
#NB self.extra_config.step_size = new_step_size
388388

389389
# if self.comm.rank == 0:
390390
# print("step_size_tune done", list(zip(done, accept_freq, step_size)))

tests/test_sample.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ def test_Morse_ASE_mpi(mpi_tmp_path, monkeypatch):
4646
do_Morse_ASE(mpi_tmp_path, monkeypatch, using_mpi=True)
4747

4848
@pytest.mark.mpi
49+
# github CI working test takes ~90 s
4950
@pytest.mark.timeout(120, method="thread")
5051
def test_Morse_ASE_restart_mpi(mpi_tmp_path, monkeypatch):
5152
import time

0 commit comments

Comments
 (0)