Fix building frameworks on MacOS

Fixes #1722

Author: SiegeLordEx

CMakeLists.txt

@@ -1256,10 +1256,6 @@ write_basic_package_version_file(${PKG_VERSION_FILE}
   VERSION ${ALLEGRO_VERSION}
   COMPATIBILITY AnyNewerVersion
 )
-install(
-  TARGETS ${ALLEGRO_TARGETS}
-  EXPORT ${PKG_TARGETS_NAME}
-)
 install(
   EXPORT ${PKG_TARGETS_NAME}
   NAMESPACE ${PKG_NAME}::
@@ -1276,6 +1272,20 @@ export(EXPORT ${PKG_TARGETS_NAME}
   NAMESPACE ${PKG_NAME}::
 )
 
+#-----------------------------------------------------------------------------#
+#
+#   Misc installation
+#
+#-----------------------------------------------------------------------------#
+
+# This lives here instead of add_our_library primarily because we only set up
+# the PKG_TARGETS_NAME here.
+install(
+  TARGETS ${ALLEGRO_TARGETS}
+  EXPORT ${PKG_TARGETS_NAME}
+  FRAMEWORK DESTINATION "${FRAMEWORK_INSTALL_PREFIX}"
+)
+
 #-----------------------------------------------------------------------------#
 #
 #   Documentation

cmake/Common.cmake

@@ -225,11 +225,6 @@ function(set_our_framework_properties target nm)
 endfunction(set_our_framework_properties)
 
 function(install_our_library target filename)
-    install(TARGETS ${target}
-            FRAMEWORK DESTINATION "${FRAMEWORK_INSTALL_PREFIX}"
-            # Doesn't work, see below.
-            # PUBLIC_HEADER DESTINATION "include"
-            )
     if(MSVC AND BUILD_SHARED_LIBS)
         install(FILES ${CMAKE_BINARY_DIR}/lib/\${CMAKE_INSTALL_CONFIG_NAME}/${filename}.pdb
             DESTINATION ${CMAKE_INSTALL_LIBDIR}