Fixes issue #1547 for skater and shooter demos: Segfault after failed audio subsystem installation on Linux. #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subsystem installation on Linux. The segfault happened in the function calls `al_reserve_samples` and `al_attach_sample_instance_to_mixer`, which have now been guarded by `if (al_is_audio_installed())`. Potentially move this check into the body of these functions?
… subsystem installation on Linux. The segfault happened in the function calls `play_midi`, `al_stop_sample`, and `al_unlock_sample_id`, which have now been guarded by `if (al_is_audio_installed())`. Potentially move this check into the body of these functions?
|
Is there a desire to have the game playing in silence? We could just exit the game if audio failed to install. |
|
Of course it is only half the fun without music and sound. But I could now play the games on a computer that had no sound card installed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.