Fix address index write for > 0th index outputs.

Author: evoskuil

include/bitcoin/database/impl/query/archive_write.ipp

@@ -192,14 +192,19 @@ code CLASS::set_code(const tx_link& tx_fk, const transaction& tx) NOEXCEPT
         if (ad_fk.is_terminal())
             return error::tx_address_allocate;
 
+        constexpr auto value_parent_diff = sizeof(uint64_t) - tx_link::size;
         const auto ptr = store_.address.get_memory();
         for (const auto& output: *ous)
         {
             if (!store_.address.put(ptr, ad_fk++, output->script().hash(),
                 table::address::record{ {}, out_fk }))
                 return error::tx_address_put;
 
-            out_fk.value += output->serialized_size();
+            // See outs::put_ref.
+            // Calculate next corresponding output fk from serialized size.
+            // (variable_size(value) + (value + script)) - (value - parent)
+            out_fk.value += (variable_size(output->value()) +
+                output->serialized_size() - value_parent_diff);
         }
     }
 

include/bitcoin/database/tables/archives/outs.hpp

@@ -106,8 +106,7 @@ struct outs
         {
             using namespace system;
             static_assert(tx::size <= sizeof(uint64_t));
-            constexpr auto value_parent_difference = sizeof(uint64_t) -
-                tx::size;
+            constexpr auto value_parent_diff = sizeof(uint64_t) - tx::size;
 
             auto out_fk = output_fk;
             const auto& outs = *tx_.outputs_ptr();
@@ -118,7 +117,7 @@ struct outs
                 // Calculate next corresponding output fk from serialized size.
                 // (variable_size(value) + (value + script)) - (value - parent)
                 out_fk += (variable_size(out->value()) + out->serialized_size() -
-                    value_parent_difference);
+                    value_parent_diff);
             });
 
             BC_ASSERT(!sink || sink.get_write_position() == count() * minrow);