Merge pull request #676 from evoskuil/master

evoskuil · web-flow · commit e90c9030f4df · 2025-10-12T10:31:43.000-04:00
Add MADV_WILLNEED to macos madvise calls.
diff --git a/src/memory/map.cpp b/src/memory/map.cpp
@@ -617,7 +617,8 @@ bool map::finalize_(size_t size) NOEXCEPT
 
     // Use 1GB chunks to avoid large-length issues.
     constexpr auto chunk = power2(30u);
-    const auto advice = random_ ? MADV_RANDOM : MADV_SEQUENTIAL;
+    const auto advice = (random_ ? MADV_RANDOM : MADV_SEQUENTIAL) |
+        MADV_WILLNEED;
 
     for (auto offset = zero; offset < align; offset += chunk)
     {

Original file line number	Diff line number	Diff line change
`@@ -617,7 +617,8 @@ bool map::finalize_(size_t size) NOEXCEPT`
`617`	`617`
`618`	`618`	`// Use 1GB chunks to avoid large-length issues.`
`619`	`619`	`constexpr auto chunk = power2(30u);`
`620`		`- const auto advice = random_ ? MADV_RANDOM : MADV_SEQUENTIAL;`
	`620`	`+ const auto advice = (random_ ? MADV_RANDOM : MADV_SEQUENTIAL) \|`
	`621`	`+ MADV_WILLNEED;`
`621`	`622`
`622`	`623`	`for (auto offset = zero; offset < align; offset += chunk)`
`623`	`624`	`{`