Merge pull request #681 from evoskuil/master

Call exception safe override of boost socket remote_endpoint.

Author: evoskuil

include/bitcoin/network/net/socket.hpp

@@ -251,7 +251,7 @@ class BCT_API socket
         const result_handler& handler) NOEXCEPT;
 
     // connection
-    void handle_accept(const boost_code& ec,
+    void handle_accept(boost_code ec,
         const result_handler& handler) NOEXCEPT;
     void handle_connect(const boost_code& ec, const asio::endpoint& peer,
         const result_handler& handler) NOEXCEPT;

src/net/socket.cpp

@@ -581,15 +581,15 @@ void socket::do_ws_event(ws::frame_type kind,
 // ----------------------------------------------------------------------------
 // These are invoked on strand upon failure, socket cancel, or completion.
 
-void socket::handle_accept(const boost_code& ec,
+void socket::handle_accept(boost_code ec,
     const result_handler& handler) NOEXCEPT
 {
     // This is running in the acceptor (not socket) execution context.
     // socket_ and authority_ are not guarded here, see comments on accept.
     // address_ remains defaulted for inbound (accepted) connections.
 
     if (!ec)
-        authority_ = { socket_.remote_endpoint() };
+        authority_ = { socket_.remote_endpoint(ec) };
 
     if (error::asio_is_canceled(ec))
     {