Merge pull request #742 from evoskuil/master

evoskuil · web-flow · commit 35d301cd7708 · 2026-03-11T10:08:34.000-07:00
Fix use after move bug in send_error.
diff --git a/include/bitcoin/network/impl/channels/channel_rpc.ipp b/include/bitcoin/network/impl/channels/channel_rpc.ipp
@@ -152,8 +152,9 @@ void CLASS::send_error(rpc::result_t&& error,
     result_handler&& handler) NOEXCEPT
 {
     BC_ASSERT(stranded());
+    const auto hint = two * error.message.size();
     send({ .jsonrpc = version_, .id = identity_, .error = std::move(error) },
-        two * error.message.size(), std::move(handler));
+        hint, std::move(handler));
 }
 
 TEMPLATE

Original file line number	Diff line number	Diff line change
`@@ -152,8 +152,9 @@ void CLASS::send_error(rpc::result_t&& error,`
`152`	`152`	`result_handler&& handler) NOEXCEPT`
`153`	`153`	`{`
`154`	`154`	`BC_ASSERT(stranded());`
	`155`	`+ const auto hint = two * error.message.size();`
`155`	`156`	`send({ .jsonrpc = version_, .id = identity_, .error = std::move(error) },`
`156`		`- two * error.message.size(), std::move(handler));`
	`157`	`+ hint, std::move(handler));`
`157`	`158`	`}`
`158`	`159`
`159`	`160`	`TEMPLATE`