Strip query string before parsing target (origin).

Author: evoskuil

src/parse/target.cpp

@@ -48,7 +48,8 @@ static hash_cptr to_hash(const std::string_view& token) NOEXCEPT
 
 code parse_target(request_t& out, const std::string_view& path) NOEXCEPT
 {
-    if (path.empty())
+    const auto clean = split(path, "?", false, false).front();
+    if (clean.empty())
         return error::empty_path;
 
     // Avoid conflict with node type.
@@ -65,7 +66,7 @@ code parse_target(request_t& out, const std::string_view& path) NOEXCEPT
 
     auto& method = out.method;
     auto& params = std::get<object_t>(out.params.value());
-    const auto segments = split(path, "/", false, true);
+    const auto segments = split(clean, "/", false, true);
     BC_ASSERT(!segments.empty());
 
     size_t segment{};

test/parse/target.cpp

@@ -29,7 +29,7 @@ using object_t = network::rpc::object_t;
 BOOST_AUTO_TEST_CASE(parse__parse_target__empty_path__empty_path)
 {
     request_t out{};
-    BOOST_REQUIRE_EQUAL(parse_target(out, ""), node::error::empty_path);
+    BOOST_REQUIRE_EQUAL(parse_target(out, "?foo=bar"), node::error::empty_path);
 }
 
 BOOST_AUTO_TEST_CASE(parse__parse_target__missing_version__missing_version)
@@ -67,7 +67,7 @@ BOOST_AUTO_TEST_CASE(parse__parse_target__invalid_target__invalid_target)
 
 BOOST_AUTO_TEST_CASE(parse__parse_target__block_hash_valid__expected)
 {
-    const std::string path = "//v42//block//hash//0000000000000000000000000000000000000000000000000000000000000042//";
+    const std::string path = "//v42//block//hash//0000000000000000000000000000000000000000000000000000000000000042//?foo=bar";
 
     request_t request{};
     BOOST_REQUIRE(!parse_target(request, path));