Fix tx relay regression, adapt to block/tx const query returns.

Author: evoskuil

include/bitcoin/node/protocols/protocol_block_out.hpp

@@ -49,11 +49,11 @@ class BCN_API protocol_block_out
     size_t locator_limit();
 
     void send_next_data(inventory_ptr inventory);
-    void send_block(const code& ec, block_ptr message,
+    void send_block(const code& ec, block_const_ptr message,
         uint64_t height, inventory_ptr inventory);
-    void send_merkle_block(const code& ec, merkle_block_ptr message,
+    void send_merkle_block(const code& ec, merkle_block_const_ptr message,
         uint64_t height, inventory_ptr inventory);
-    void send_compact_block(const code& ec, compact_block_ptr message,
+    void send_compact_block(const code& ec, compact_block_const_ptr message,
         uint64_t height, inventory_ptr inventory);
 
     bool handle_receive_get_data(const code& ec,

include/bitcoin/node/protocols/protocol_transaction_out.hpp

@@ -46,7 +46,7 @@ class BCN_API protocol_transaction_out
 
 private:
     void send_next_data(inventory_ptr inventory);
-    void send_transaction(const code& ec, transaction_ptr transaction,
+    void send_transaction(const code& ec, transaction_const_ptr transaction,
         size_t height, size_t position, inventory_ptr inventory);
 
     bool handle_receive_get_data(const code& ec,

src/protocols/protocol_block_out.cpp

@@ -310,7 +310,7 @@ void protocol_block_out::send_next_data(inventory_ptr inventory)
     }
 }
 
-void protocol_block_out::send_block(const code& ec, block_ptr message,
+void protocol_block_out::send_block(const code& ec, block_const_ptr message,
     uint64_t, inventory_ptr inventory)
 {
     if (stopped(ec))
@@ -343,7 +343,7 @@ void protocol_block_out::send_block(const code& ec, block_ptr message,
 
 // TODO: move merkle_block to derived class protocol_block_out_70001.
 void protocol_block_out::send_merkle_block(const code& ec,
-    merkle_block_ptr message, uint64_t, inventory_ptr inventory)
+    merkle_block_const_ptr message, uint64_t, inventory_ptr inventory)
 {
     if (stopped(ec))
         return;
@@ -375,7 +375,7 @@ void protocol_block_out::send_merkle_block(const code& ec,
 
 // TODO: move merkle_block to derived class protocol_block_out_70014.
 void protocol_block_out::send_compact_block(const code& ec,
-    compact_block_ptr message, uint64_t, inventory_ptr inventory)
+    compact_block_const_ptr message, uint64_t, inventory_ptr inventory)
 {
     if (stopped(ec))
         return;

src/protocols/protocol_transaction_out.cpp

@@ -176,7 +176,7 @@ void protocol_transaction_out::send_next_data(inventory_ptr inventory)
 
 // TODO: send block_transaction message as applicable.
 void protocol_transaction_out::send_transaction(const code& ec,
-    transaction_ptr transaction, size_t, size_t position,
+    transaction_const_ptr transaction, size_t position, size_t /*height*/,
     inventory_ptr inventory)
 {
     if (stopped(ec))