Use namespace, use const&.

Author: evoskuil

include/bitcoin/node/protocols/protocol_explore.hpp

@@ -72,36 +72,36 @@ class BCN_API protocol_explore
     ////bool handle_get_block_txs(const code& ec, interface::block_txs,
     ////    uint8_t version, uint8_t media, std::optional<system::hash_cptr> hash,
     ////    std::optional<uint32_t> height) NOEXCEPT;
-    ////
+
     ////bool handle_get_block_tx(const code& ec, interface::block_tx,
     ////    uint8_t version, uint8_t media, uint32_t position,
     ////    std::optional<system::hash_cptr> hash,
     ////    std::optional<uint32_t> height, bool witness) NOEXCEPT;
-    ////
+
     bool handle_get_transaction(const code& ec, interface::transaction,
-        uint8_t version, uint8_t media, system::hash_cptr hash,
+        uint8_t version, uint8_t media, const system::hash_cptr& hash,
         bool witness) NOEXCEPT;
     ////bool handle_get_address(const code& ec, interface::address,
-    ////    uint8_t version, uint8_t media, system::hash_cptr hash) NOEXCEPT;
-    ////
+    ////    uint8_t version, uint8_t media, const system::hash_cptr& hash) NOEXCEPT;
+
     ////bool handle_get_input(const code& ec, interface::input,
-    ////    uint8_t version, uint8_t media, system::hash_cptr hash,
+    ////    uint8_t version, uint8_t media, const system::hash_cptr& hash,
     ////    std::optional<uint32_t> index) NOEXCEPT;
     ////bool handle_get_input_script(const code& ec, interface::input_script,
-    ////    uint8_t version, uint8_t media, system::hash_cptr hash,
+    ////    uint8_t version, uint8_t media, const system::hash_cptr& hash,
     ////    std::optional<uint32_t> index) NOEXCEPT;
     ////bool handle_get_input_witness(const code& ec, interface::input_witness,
-    ////    uint8_t version, uint8_t media, system::hash_cptr hash,
+    ////    uint8_t version, uint8_t media, const system::hash_cptr& hash,
     ////    std::optional<uint32_t> index) NOEXCEPT;
-    ////
+
     ////bool handle_get_output(const code& ec, interface::output,
-    ////    uint8_t version, uint8_t media, system::hash_cptr hash,
+    ////    uint8_t version, uint8_t media, const system::hash_cptr& hash,
     ////    std::optional<uint32_t> index) NOEXCEPT;
     ////bool handle_get_output_script(const code& ec, interface::output_script,
-    ////    uint8_t version, uint8_t media, system::hash_cptr hash,
+    ////    uint8_t version, uint8_t media, const system::hash_cptr& hash,
     ////    std::optional<uint32_t> index) NOEXCEPT;
     ////bool handle_get_output_spender(const code& ec, interface::output_spender,
-    ////    uint8_t version, uint8_t media, system::hash_cptr hash,
+    ////    uint8_t version, uint8_t media, const system::hash_cptr& hash,
     ////    std::optional<uint32_t> index) NOEXCEPT;
 
 private:

src/protocols/protocol_explore.cpp

@@ -101,7 +101,7 @@ bool protocol_explore::try_dispatch_object(const request& request) NOEXCEPT
 // ----------------------------------------------------------------------------
 
 bool protocol_explore::handle_get_block(const code& ec, interface::block,
-    uint8_t, uint8_t media, std::optional<system::hash_cptr> hash,
+    uint8_t, uint8_t media, std::optional<hash_cptr> hash,
     std::optional<uint32_t> height, bool witness) NOEXCEPT
 {
     BC_ASSERT(stranded());
@@ -139,7 +139,7 @@ bool protocol_explore::handle_get_block(const code& ec, interface::block,
 }
 
 bool protocol_explore::handle_get_header(const code& ec, interface::header,
-    uint8_t, uint8_t media, std::optional<system::hash_cptr> hash,
+    uint8_t, uint8_t media, std::optional<hash_cptr> hash,
     std::optional<uint32_t> height) NOEXCEPT
 {
     BC_ASSERT(stranded());
@@ -177,7 +177,7 @@ bool protocol_explore::handle_get_header(const code& ec, interface::header,
 }
 
 bool protocol_explore::handle_get_transaction(const code& ec,
-    interface::transaction, uint8_t, uint8_t media, system::hash_cptr hash,
+    interface::transaction, uint8_t, uint8_t media, const hash_cptr& hash,
     bool witness) NOEXCEPT
 {
     BC_ASSERT(stranded());