Disable tx relay at the protocol level if chain is stale.

Author: evoskuil

src/protocols/protocol_transaction_in.cpp

@@ -87,7 +87,7 @@ void protocol_transaction_in::start()
     }
 
     // TODO: move memory_pool to a derived class protocol_transaction_in_60002.
-    if (refresh_pool_ && relay_from_peer_)
+    if (refresh_pool_ && relay_from_peer_ && !chain_.is_stale())
     {
         // Refresh transaction pool on connect.
         SEND2(memory_pool{}, handle_send, _1, memory_pool::command);
@@ -118,6 +118,11 @@ bool protocol_transaction_in::handle_receive_inventory(const code& ec,
         return false;
     }
 
+    // TODO: manage channel relay at the service layer.
+    // Do not process tx inventory while chain is stale.
+    if (chain_.is_stale())
+        return true;
+
     // Remove hashes of (unspent) transactions that we already have.
     // BUGBUG: this removes spent transactions which it should not (see BIP30).
     chain_.filter_transactions(response, BIND2(send_get_data, _1, response));
@@ -146,6 +151,7 @@ void protocol_transaction_in::send_get_data(const code& ec,
 // Receive transaction sequence.
 //-----------------------------------------------------------------------------
 
+// A transaction is acceptable whether solicited or broadcast.
 bool protocol_transaction_in::handle_receive_transaction(const code& ec,
     transaction_const_ptr message)
 {
@@ -162,6 +168,11 @@ bool protocol_transaction_in::handle_receive_transaction(const code& ec,
         return false;
     }
 
+    // TODO: manage channel relay at the service layer.
+    // Do not process transactions while chain is stale.
+    if (chain_.is_stale())
+        return true;
+
     message->validation.originator = nonce();
     chain_.organize(message, BIND2(handle_store_transaction, _1, message));
     return true;