Update fault codes, balance confirmation threads.

Author: evoskuil

include/bitcoin/node/error.hpp

@@ -53,39 +53,52 @@ enum error_t : uint8_t
     suspended_service,
 
     /// blockchain
-    branch_error,
     orphan_block,
     orphan_header,
     duplicate_block,
     duplicate_header,
-    ////validation_bypass,
-    ////confirmation_bypass,
 
-    /// chasers
-    set_block_unconfirmable,
-    get_height,
-    get_branch_work,
-    get_is_strong,
-    invalid_branch_point,
-    pop_candidate,
-    push_candidate,
-    invalid_fork_point,
-    get_candidate_chain_state,
-    get_block,
-    get_unassociated,
-    get_fork_work,
-    to_confirmed,
-    pop_confirmed,
-    get_block_confirmable,
-    get_block_state,
-    set_strong,
-    set_unstrong,
-    set_organized,
-    set_block_confirmable,
-    set_block_valid,
-    node_confirm,
-    node_validate,
-    node_roll_back
+    /// faults (terminal, code error and store corruption assumed)
+    protocol1,
+    header1,
+    organize1,
+    organize2,
+    organize3,
+    organize4,
+    organize5,
+    organize6,
+    organize7,
+    organize8,
+    organize9,
+    organize10,
+    organize11,
+    organize12,
+    organize13,
+    organize14,
+    organize15,
+    validate1,
+    validate2,
+    validate3,
+    validate4,
+    validate5,
+    validate6,
+    confirm1,
+    confirm2,
+    confirm3,
+    confirm4,
+    confirm5,
+    confirm6,
+    confirm7,
+    confirm8,
+    confirm9,
+    confirm10,
+    confirm11,
+    confirm12,
+    confirm13,
+    confirm14,
+    confirm15,
+    confirm16,
+    confirm17
 };
 
 // No current need for error_code equivalence mapping.

include/bitcoin/node/impl/chasers/chaser_organize.ipp

@@ -57,8 +57,8 @@ code CLASS::start() NOEXCEPT
 
     if (!state_)
     {
-        fault(error::get_candidate_chain_state);
-        return error::get_candidate_chain_state;
+        fault(error::organize1);
+        return error::organize1;
     }
 
     LOGN("Candidate top [" << system::encode_hash(state_->hash()) << ":"
@@ -205,14 +205,14 @@ void CLASS::do_organize(typename Block::cptr block,
 
     if (!get_branch_work(work, branch_point, tree_branch, store_branch, header))
     {
-        handler(fault(error::get_branch_work), height);
+        handler(fault(error::organize2), height);
         return;
     }
 
     // branch_point is the highest tree-candidate common block.
     if (!get_is_strong(strong, work, branch_point))
     {
-        handler(fault(error::get_is_strong), height);
+        handler(fault(error::organize3), height);
         return;
     }
 
@@ -235,7 +235,7 @@ void CLASS::do_organize(typename Block::cptr block,
     const auto top_candidate = state_->height();
     if (branch_point > top_candidate)
     {
-        handler(fault(error::invalid_branch_point), height);
+        handler(fault(error::organize4), height);
         return;
     }
 
@@ -247,7 +247,7 @@ void CLASS::do_organize(typename Block::cptr block,
         if ((is_under_milestone(index) && !query.set_unstrong(candidate)) ||
             !query.pop_candidate())
         {
-            handler(fault(error::pop_candidate), height);
+            handler(fault(error::organize5), height);
             return;
         }
 
@@ -264,7 +264,7 @@ void CLASS::do_organize(typename Block::cptr block,
         if ((is_under_milestone(index) && !query.set_strong(link)) ||
             !query.push_candidate(link))
         {
-            handler(fault(error::push_candidate), height);
+            handler(fault(error::organize6), height);
             return;
         }
 
@@ -347,15 +347,15 @@ void CLASS::do_disorganize(header_t link) NOEXCEPT
     size_t height{};
     if (!query.get_height(height, link) || is_zero(height))
     {
-        fault(error::get_height);
+        fault(error::organize7);
         return;
     }
 
     // Must reorganize down to fork point, since entire branch is now weak.
     const auto fork_point = query.get_fork();
     if (height <= fork_point)
     {
-        fault(error::invalid_fork_point);
+        fault(error::organize8);
         return;
     }
 
@@ -365,7 +365,7 @@ void CLASS::do_disorganize(header_t link) NOEXCEPT
     auto state = query.get_candidate_chain_state(settings_, fork_point);
     if (!state)
     {
-        fault(error::get_candidate_chain_state);
+        fault(error::organize9);
         return;
     }
 
@@ -378,7 +378,7 @@ void CLASS::do_disorganize(header_t link) NOEXCEPT
     {
         if (!get_block(block, index))
         {
-            fault(error::get_block);
+            fault(error::organize10);
             return;
         }
 
@@ -398,7 +398,7 @@ void CLASS::do_disorganize(header_t link) NOEXCEPT
         if ((is_under_milestone(index) && !query.set_unstrong(candidate)) ||
             !query.pop_candidate())
         {
-            fault(error::pop_candidate);
+            fault(error::organize11);
             return;
         }
 
@@ -418,7 +418,7 @@ void CLASS::do_disorganize(header_t link) NOEXCEPT
         // Confirmed are already set_strong and must stay that way.
         if (!query.push_candidate(query.to_confirmed(index)))
         {
-            fault(error::push_candidate);
+            fault(error::organize12);
             return;
         }
 
@@ -428,7 +428,7 @@ void CLASS::do_disorganize(header_t link) NOEXCEPT
     state = query.get_candidate_chain_state(settings_, top_confirmed);
     if (!state)
     {
-        fault(error::get_candidate_chain_state);
+        fault(error::organize13);
         return;
     }
 
@@ -552,7 +552,7 @@ code CLASS::push_block(const Block& block,
         return ec;
 
     if (!query.push_candidate(link))
-        return error::push_candidate;
+        return error::organize14;
 
     return ec;
 }
@@ -562,7 +562,7 @@ code CLASS::push_block(const system::hash_digest& key) NOEXCEPT
 {
     const auto handle = tree_.extract(key);
     if (!handle)
-        return error::branch_error;
+        return error::organize15;
 
     const auto& value = handle.mapped();
     return push_block(*value.block, value.state->context());