Add rpc return error codes.

Author: evoskuil

include/bitcoin/node/error.hpp

@@ -118,8 +118,10 @@ enum error_t : uint8_t
     invalid_subcomponent,
     extra_segment,
 
-    /// server (json-rpc parse codes)
-    unexpected_parse
+    /// server (rpc response codes)
+    not_found,
+    invalid_argument,
+    not_implemented
 };
 
 // No current need for error_code equivalence mapping.

src/error.cpp

@@ -49,7 +49,7 @@ DEFINE_ERROR_T_MESSAGE_MAP(error)
     { duplicate_block, "duplicate block" },
     { duplicate_header, "duplicate header" },
 
-    /// faults
+    // faults
     { protocol1, "protocol1" },
     { protocol2, "protocol2" },
     { header1, "header1" },
@@ -90,7 +90,7 @@ DEFINE_ERROR_T_MESSAGE_MAP(error)
     { confirm12, "confirm12" },
     { confirm13, "confirm13" },
 
-    /// server (url parse codes)
+    // server (url parse codes)
     { empty_path, "empty_path" },
     { invalid_number, "invalid_number" },
     { invalid_hash, "invalid_hash" },
@@ -107,7 +107,11 @@ DEFINE_ERROR_T_MESSAGE_MAP(error)
     { invalid_component, "invalid_component" },
     { invalid_subcomponent, "invalid_subcomponent" },
     { extra_segment, "extra_segment" },
-    { unexpected_parse, "unexpected_parse" }
+
+    // server (rpc response codes)
+    { not_found, "not_found" },
+    { invalid_argument, "invalid_argument" },
+    { not_implemented, "not_implemented" }
 };
 
 DEFINE_ERROR_T_CATEGORY(error, "node", "node code")

test/error.cpp

@@ -371,13 +371,33 @@ BOOST_AUTO_TEST_CASE(error_t__code__extra_segment__true_exected_message)
     BOOST_REQUIRE_EQUAL(ec.message(), "extra_segment");
 }
 
-BOOST_AUTO_TEST_CASE(error_t__code__unexpected_parse__true_exected_message)
+// server (rpc response codes)
+
+BOOST_AUTO_TEST_CASE(error_t__code__not_found__true_exected_message)
+{
+    constexpr auto value = error::not_found;
+    const auto ec = code(value);
+    BOOST_REQUIRE(ec);
+    BOOST_REQUIRE(ec == value);
+    BOOST_REQUIRE_EQUAL(ec.message(), "not_found");
+}
+
+BOOST_AUTO_TEST_CASE(error_t__code__invalid_argument__true_exected_message)
+{
+    constexpr auto value = error::invalid_argument;
+    const auto ec = code(value);
+    BOOST_REQUIRE(ec);
+    BOOST_REQUIRE(ec == value);
+    BOOST_REQUIRE_EQUAL(ec.message(), "invalid_argument");
+}
+
+BOOST_AUTO_TEST_CASE(error_t__code__not_implemented__true_exected_message)
 {
-    constexpr auto value = error::unexpected_parse;
+    constexpr auto value = error::not_implemented;
     const auto ec = code(value);
     BOOST_REQUIRE(ec);
     BOOST_REQUIRE(ec == value);
-    BOOST_REQUIRE_EQUAL(ec.message(), "unexpected_parse");
+    BOOST_REQUIRE_EQUAL(ec.message(), "not_implemented");
 }
 
 BOOST_AUTO_TEST_SUITE_END()