Merge pull request #704 from evoskuil/master

Provide error code with directory create failure.

Author: evoskuil

console/executor_store.cpp

@@ -59,9 +59,9 @@ bool executor::check_store_path(bool create) const
     if (create)
     {
         logger(format(BN_INITIALIZING_CHAIN) % store);
-        if (!database::file::create_directory(store))
+        if (auto ec = database::file::create_directory_ex(store))
         {
-            logger(format(BN_INITCHAIN_EXISTS) % store);
+            logger(format(BN_INITCHAIN_DIRECTORY_ERROR) % store % ec.message());
             return false;
         }
     }

console/localize.hpp

@@ -38,8 +38,8 @@ namespace node {
 // --initchain
 #define BN_INITIALIZING_CHAIN \
     "Initializing %1% directory..."
-#define BN_INITCHAIN_EXISTS \
-    "Failed because the directory %1% already exists."
+#define BN_INITCHAIN_DIRECTORY_ERROR \
+    "Failed creating directory %1% with error '%2%'."
 #define BN_INITCHAIN_CREATING \
     "Please wait while creating the database..."
 #define BN_INITCHAIN_CREATED \

src/chasers/chaser_validate.cpp

@@ -347,10 +347,14 @@ bool chaser_validate::update_neutrino(const header_link& link,
     if (!query.neutrino_enabled())
         return true;
 
+    // Filters are computed during validate, in parallel.
+    // Validation skipped under checkpoint/milestone to only compute filter.
     data_chunk filter{};
     if (!compute_filter(filter, block))
         return false;
 
+    // TODO: move filter header computation to confirmation chaser (ordered).
+    // TODO: this requires distinct storage array[n, 256] for filter headers.
     neutrino_ = compute_filter_header(neutrino_, filter);
     return query.set_filter(link, neutrino_, filter);
 }