Rename priority setting, fix test.

Author: evoskuil

include/bitcoin/node/settings.hpp

@@ -72,8 +72,8 @@ class BCN_API settings
     settings(system::chain::selection context) NOEXCEPT;
 
     /// Properties.
+    bool priority;
     bool headers_first;
-    bool priority_validation;
     float allowed_deviation;
     uint16_t allocation_multiple;
     uint64_t snapshot_bytes;

src/parser.cpp

@@ -906,8 +906,8 @@ options_metadata parser::load_settings() THROWS
         "The number of threads in the validation threadpool, defaults to 16."
     )
     (
-        "node.priority_validation",
-        value<bool>(&configured.node.priority_validation),
+        "node.priority",
+        value<bool>(&configured.node.priority),
         "Set the validation threadpool to high priority, defaults to true."
     )
     (

src/settings.cpp

@@ -75,8 +75,8 @@ std::filesystem::path settings::events_file() const NOEXCEPT
 namespace node {
 
 settings::settings() NOEXCEPT
-  : headers_first{ true },
-    priority_validation{ true },
+  : priority{ true },
+    headers_first{ true },
     allowed_deviation{ 1.5 },
     allocation_multiple{ 20 },
     snapshot_bytes{ 200'000'000'000 },
@@ -123,7 +123,7 @@ network::wall_clock::duration settings::currency_window() const NOEXCEPT
 
 network::thread_priority settings::priority_() const NOEXCEPT
 {
-    return priority_validation ? network::thread_priority::high :
+    return priority ? network::thread_priority::high :
         network::thread_priority::normal;
 }
 

test/settings.cpp

@@ -54,8 +54,8 @@ BOOST_AUTO_TEST_CASE(settings__node__default_context__expected)
     using namespace network;
 
     const node::settings node{};
+    BOOST_REQUIRE_EQUAL(node.priority, true);
     BOOST_REQUIRE_EQUAL(node.headers_first, true);
-    BOOST_REQUIRE_EQUAL(node.priority_validation, true);
     BOOST_REQUIRE_EQUAL(node.allowed_deviation, 1.5);
     BOOST_REQUIRE_EQUAL(node.maximum_height, 0_u32);
     BOOST_REQUIRE_EQUAL(node.allocation_multiple, 20_u16);
@@ -74,7 +74,7 @@ BOOST_AUTO_TEST_CASE(settings__node__default_context__expected)
     BOOST_REQUIRE_EQUAL(node.maximum_concurrency_(), 50'000_size);
     BOOST_REQUIRE(node.sample_period() == steady_clock::duration(seconds(10)));
     BOOST_REQUIRE(node.currency_window() == steady_clock::duration(minutes(60)));
-    BOOST_REQUIRE(node.priority_() == network::thread_priority::normal);
+    BOOST_REQUIRE(node.priority_() == network::thread_priority::high);
 }
 
 BOOST_AUTO_TEST_SUITE_END()