Change to bounded behavior per PR suggestions

xloem · xloem · commit ca5947bcaade · 2020-10-23T18:26:11.000-04:00
diff --git a/src/zmq/certificate.cpp b/src/zmq/certificate.cpp
@@ -79,7 +79,7 @@ bool certificate::create(config::sodium& out_public,
 {
     // Loop until neither key's base85 encoding includes the # character.
     // This ensures that the value can be used in libbitcoin settings files.
-    while (true)
+    for (uint8_t attempt = 0; attempt < max_uint8; attempt++)
     {
         char public_key[zmq_encoded_key_size + 1] = { 0 };
         char private_key[zmq_encoded_key_size + 1] = { 0 };
@@ -95,6 +95,8 @@ bool certificate::create(config::sodium& out_public,
             return out_public;
         }
     }
+
+    return false;
 }
 
 certificate::operator bool() const

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ bool certificate::create(config::sodium& out_public,`
`79`	`79`	`{`
`80`	`80`	`// Loop until neither key's base85 encoding includes the # character.`
`81`	`81`	`// This ensures that the value can be used in libbitcoin settings files.`
`82`		`- while (true)`
	`82`	`+ for (uint8_t attempt = 0; attempt < max_uint8; attempt++)`
`83`	`83`	`{`
`84`	`84`	`char public_key[zmq_encoded_key_size + 1] = { 0 };`
`85`	`85`	`char private_key[zmq_encoded_key_size + 1] = { 0 };`
`@@ -95,6 +95,8 @@ bool certificate::create(config::sodium& out_public,`
`95`	`95`	`return out_public;`
`96`	`96`	`}`
`97`	`97`	`}`
	`98`	`+`
	`99`	`+ return false;`
`98`	`100`	`}`
`99`	`101`
`100`	`102`	`certificate::operator bool() const`