Explicitly quote the ICU_LIB shell expansion (resolves #1130).

Update clang compiler version to 5.0.

Author: thecodefactory

.travis.yml

@@ -35,7 +35,7 @@ matrix:
               sources:
                 - sourceline: 'ppa:h-rayflood/llvm'
               packages:
-                - clang-3.8
+                - clang-5.0
         - os: linux
           compiler: gcc
           env: LINK=dynamic
@@ -66,7 +66,7 @@ install:
 
     # Export CC/CXX to control compiler/version.
     - if [[ $OSX   && $CLANG && $STATIC  ]]; then export CC=clang; export CXX=clang++; fi
-    - if [[ $LINUX && $CLANG && $STATIC  ]]; then export CC=clang-3.8; export CXX=clang++-3.8; fi
+    - if [[ $LINUX && $CLANG && $STATIC  ]]; then export CC=clang-5.0; export CXX=clang++-5.0; fi
     - if [[ $LINUX && $GCC   && $STATIC  ]]; then export CC=gcc; export CXX=g++; fi
     - if [[ $OSX   && $CLANG && $DYNAMIC ]]; then export CC=clang; export CXX=clang++; fi
     - if [[ $LINUX && $CLANG && $DYNAMIC ]]; then export CC=clang; export CXX=clang++; fi

builds/cmake/CMakeLists.txt

@@ -113,7 +113,7 @@ set( boost_LDFLAGS "-L${Boost_LIBRARY_DIR}" )
 
 # Find zmq
 #------------------------------------------------------------------------------
-find_package( Zmq 4.2.5 REQUIRED )
+find_package( Zmq 4.3.2 REQUIRED )
 
 # Find mbedtls
 #------------------------------------------------------------------------------

configure.ac

@@ -161,14 +161,14 @@ AS_CASE([${with_tests}], [yes],
      AC_MSG_NOTICE([boost_unit_test_framework_LIBS : ${boost_unit_test_framework_LIBS}])],
     [AC_SUBST([boost_unit_test_framework_LIBS], [])])
 
-# Require zmq of at least version 4.2.5 and output ${zmq_CPPFLAGS/LIBS/PKG}.
+# Require zmq of at least version 4.3.2 and output ${zmq_CPPFLAGS/LIBS/PKG}.
 #------------------------------------------------------------------------------
-PKG_CHECK_MODULES([zmq], [libzmq >= 4.2.5],
-    [zmq_INCLUDEDIR="`$PKG_CONFIG --variable=includedir "libzmq >= 4.2.5" 2>/dev/null`"
-     zmq_OTHER_CFLAGS="`$PKG_CONFIG --cflags-only-other "libzmq >= 4.2.5" 2>/dev/null`"],
+PKG_CHECK_MODULES([zmq], [libzmq >= 4.3.2],
+    [zmq_INCLUDEDIR="`$PKG_CONFIG --variable=includedir "libzmq >= 4.3.2" 2>/dev/null`"
+     zmq_OTHER_CFLAGS="`$PKG_CONFIG --cflags-only-other "libzmq >= 4.3.2" 2>/dev/null`"],
     [zmq_INCLUDEDIR=""
      zmq_OTHER_CFLAGS=""])
-AC_SUBST([zmq_PKG], ['libzmq >= 4.2.5'])
+AC_SUBST([zmq_PKG], ['libzmq >= 4.3.2'])
 AC_SUBST([zmq_CPPFLAGS], [${zmq_CFLAGS}])
 AS_IF([test x${zmq_INCLUDEDIR} != "x"],
     [AC_SUBST([zmq_ISYS_CPPFLAGS], ["-isystem${zmq_INCLUDEDIR} ${zmq_OTHER_CFLAGS}"])],

install.sh

@@ -37,8 +37,8 @@ BUILD_DIR="build-libbitcoin-protocol"
 
 # ZMQ archive.
 #------------------------------------------------------------------------------
-ZMQ_URL="https://github.com/zeromq/libzmq/releases/download/v4.2.5/zeromq-4.2.5.tar.gz"
-ZMQ_ARCHIVE="zeromq-4.2.5.tar.gz"
+ZMQ_URL="https://github.com/zeromq/libzmq/releases/download/v4.3.2/zeromq-4.3.2.tar.gz"
+ZMQ_ARCHIVE="zeromq-4.3.2.tar.gz"
 
 # MBEDTLS archive.
 #------------------------------------------------------------------------------
@@ -546,7 +546,7 @@ initialize_boost_icu_configuration()
         BOOST_ICU_POSIX="off"
 
         # Extract ICU libs from package config variables and augment with -ldl.
-        ICU_LIBS=( `pkg-config icu-i18n --libs` "-ldl" )
+        ICU_LIBS="`pkg-config icu-i18n --libs` -ldl"
 
         # This is a hack for boost m4 scripts that fail with ICU dependency.
         # See custom edits in ax-boost-locale.m4 and ax_boost_regex.m4.

libbitcoin-protocol.pc.in

@@ -25,7 +25,7 @@ Version: @PACKAGE_VERSION@
 #==============================================================================
 # Dependencies that publish package configuration.
 #------------------------------------------------------------------------------
-Requires: libzmq >= 4.2.5 libbitcoin-system >= 4.0.0
+Requires: libzmq >= 4.3.2 libbitcoin-system >= 4.0.0
 
 # Include directory and any other required compiler flags.
 #------------------------------------------------------------------------------