Merge pull request #664 from evoskuil/master

Change currency_window_minutes default text to 1440.

Author: evoskuil

src/parser.cpp

@@ -1328,7 +1328,7 @@ options_metadata parser::load_settings() THROWS
     (
         "node.currency_window_minutes",
         value<uint32_t>(&configured.node.currency_window_minutes),
-        "Time from present that blocks are considered current, defaults to '60' (0 disables)."
+        "Time from present that blocks are considered current, defaults to '1440' (0 disables)."
     )
     // #######################
     ////(

src/protocols/protocol_electrum.cpp

@@ -474,6 +474,7 @@ void protocol_electrum::handle_blockchain_transaction_get(const code& ec,
     const auto size = tx->serialized_size(true);
     if (verbose)
     {
+        // TODO: inject contextual tx properties.
         // Verbose means whatever bitcoind returns for getrawtransaction, lolz.
         send_result(value_from(bitcoind(*tx)), two * size, BIND(complete, _1));
     }

test/protocols/electrum/electrum_transactions.cpp

@@ -126,6 +126,7 @@ BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__genesis_coinbase_verb
     BOOST_CHECK_EQUAL(response.at("result").as_string(), encode_base16(coinbase.to_data(true)));
 }
 
+// TODO: the expectation doesn't acocunt for contextual tx properties.
 BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__genesis_coinbase_verbose_true__expected)
 {
     BOOST_CHECK(handshake());